Skip to content

refactor(data-git): apply the data-layer review - #141

Merged
dwikiriyadi merged 1 commit into
mainfrom
refactor/data-layer-review
Nov 15, 2026
Merged

dwikiriyadi merged 1 commit into
mainfrom
refactor/data-layer-review

Conversation

@dwikiriyadi

Copy link
Copy Markdown
Member

Applies the author's review of the G1 data layer (Tasks 3–7).

What

  • Rename:
    • RepositoryRepository → RepositoryAccessRepository
    • GitRepositoryRepository → GitRepositoryAccessRepository
    • GitDataModule.repositories → GitDataModule.access
    • The interface and class were renamed with GitNexus, using graph edits only. The property and the test class were renamed by hand.
  • Notes, edited in the author's vault at their request and synced to docs/design/:
    • Storage Formats: a row for app-state.json.
    • Settings Reference: a "Diff style" row (unified or side by side, app scope).
    • Conventions: the OWN error type.
  • Ledger: the review's outcome. Identity stays in :module:data:git until G3's profiles. The other rulings stand, and the data layer stays split by source (ADR-24).
  • AGENTS.md: next is G1 Task 8.

Checks

./gradlew check passes. The renamed test runs 12 of 12. GitNexus reports no affected execution flows.

🤖 Generated with Claude Code

Rename RepositoryRepository to RepositoryAccessRepository (property
GitDataModule.access). Sync the notes the review filled in: the
app-state.json row in Storage Formats, the diff style setting, and
the OWN error type. Record the review in the ledger.

Co-Authored-By: Claude Opus 5.5 <[email protected]>
Signed-off-by: Dwiki Riyadi <[email protected]>
@dwikiriyadi
dwikiriyadi merged commit 9b10867 into main Nov 15, 2026
6 checks passed
@dwikiriyadi
dwikiriyadi deleted the refactor/data-layer-review branch November 15, 2026 22:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant