Repository navigation
Cancel the delayed connection notice when the connection is restored - #84
Open
RodolfoSilva wants to merge 1 commit into
Open
RodolfoSilva wants to merge 1 commit into
RodolfoSilva wants to merge 1 commit into
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #83
When the LiveView connection drops and comes back within
client_error_delay(3000ms by default), theshow-errorlistener still reveals#client-erroronce the delay ends, afterhide-erroralready ran. The notice then stays on screen while the page is connected, andphx-update="ignore"means no server render clears it.#server-errorgoes through the same listener.The listener now keeps the pending
setTimeoutandhide-errorclears it, so a reconnect inside the delay never shows the notice. A connection that stays down past the delay still shows it, andhide-errorstill hides it as before. The change touches only the two listeners inassets/js/live_toast/live_toast.ts, the rebuiltpriv/staticartifacts, one test inassets/test/live_toast.test.ts, andCHANGELOG.md.main(1ef5300)cd assets && bun testafter the fixcd assets && bun run typecheckcd demo && mix testmix format --check-formattedBefore / After
A single-file LiveView app with the default
toast_group, a socket indicator pollingliveSocket.isConnected(), and a button that runsliveSocket.disconnect(); setTimeout(() => liveSocket.connect(), 1500). Same steps in both recordings.main)before.mp4
after.mp4