Skip to content

feat(app): enable the supported relay by default - #921

Open
frahlg wants to merge 1 commit into
masterfrom
agent/default-app-link-on
Open

feat(app): enable the supported relay by default#921
frahlg wants to merge 1 commit into
masterfrom
agent/default-app-link-on

Conversation

@frahlg

@frahlg frahlg commented Aug 16, 2026

Copy link
Copy Markdown
Member

What changes

  • Treat an omitted app_link section as enabled, so upgraded boxes use the supported FTW app relay without a YAML edit.
  • Preserve app_link.enabled: false and an empty app_link: {} as opt-outs.
  • Keep the Settings fallback in step with Core and make the example config show the default.
  • State the privacy boundary plainly: relay frames are end-to-end encrypted, but the relay still sees source IP, timing, and connection continuity.
  • Update the app-uplink ADR to match the shipped pairing, device-removal, and owner rules.

The relay endpoint and protocol remain fixed. This change does not alter pairing keys, command checks, or hardware control.

Compatibility proof

The new round-trip test starts with an old YAML file that has no app_link, loads it, fetches it through GET /api/config, saves that response through POST /api/config, reads the file again, and proves the app link stays on after restart. Separate tests keep explicit false and an empty section off.

Verification

  • make verify
  • go test -race ./internal/config ./cmd/ftw ./internal/appuplink ./internal/appenroll ./internal/api
  • npm test — 339 passed

Release order

Merge this before the generated Version Packages PR #824. Changesets must then refresh #824 so the corrected privacy text and the default-on behavior appear in the 2.0.0 changelog. Do not merge #824 from its current head.

The Settings change still needs a human browser check on mobile and desktop during the beta: omitted config, explicit opt-out, toggle/restart copy, status, pairing, and QR layout.

@frahlg
frahlg force-pushed the agent/default-app-link-on branch from 8dfaf61 to 00efc21 Compare August 16, 2026 17:36
@frahlg
frahlg marked this pull request as ready for review August 16, 2026 17:38

@chatgpt-codex-connector chatgpt-codex-connector Bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

💡 Codex Review

Here are some automated review suggestions for this pull request.

Reviewed commit: 00efc21186

ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".

Comment thread go/internal/config/config.go
@frahlg
frahlg force-pushed the agent/default-app-link-on branch from 00efc21 to 16cecec Compare August 16, 2026 17:47
@frahlg

frahlg commented Aug 16, 2026

Copy link
Copy Markdown
Member Author

@miravoss26 could you review exact head 16cecec0? It enables the supported relay by default while preserving explicit YAML null/false opt-outs. Focused tests, race, full make verify, full-stack CI, and all required GitHub checks are green. The one automated review finding is fixed and resolved.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant