feat(app): enable the supported relay by default - #921
Open
frahlg wants to merge 1 commit into
Open
Conversation
frahlg
force-pushed
the
agent/default-app-link-on
branch
from
August 16, 2026 17:36
8dfaf61 to
00efc21
Compare
frahlg
marked this pull request as ready for review
August 16, 2026 17:38
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: 00efc21186
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
Signed-off-by: Fredrik Ahlgren <[email protected]>
frahlg
force-pushed
the
agent/default-app-link-on
branch
from
August 16, 2026 17:47
00efc21 to
16cecec
Compare
Member
Author
|
@miravoss26 could you review exact head |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What changes
app_linksection as enabled, so upgraded boxes use the supported FTW app relay without a YAML edit.app_link.enabled: falseand an emptyapp_link: {}as opt-outs.The relay endpoint and protocol remain fixed. This change does not alter pairing keys, command checks, or hardware control.
Compatibility proof
The new round-trip test starts with an old YAML file that has no
app_link, loads it, fetches it throughGET /api/config, saves that response throughPOST /api/config, reads the file again, and proves the app link stays on after restart. Separate tests keep explicit false and an empty section off.Verification
make verifygo test -race ./internal/config ./cmd/ftw ./internal/appuplink ./internal/appenroll ./internal/apinpm test— 339 passedRelease order
Merge this before the generated Version Packages PR #824. Changesets must then refresh #824 so the corrected privacy text and the default-on behavior appear in the 2.0.0 changelog. Do not merge #824 from its current head.
The Settings change still needs a human browser check on mobile and desktop during the beta: omitted config, explicit opt-out, toggle/restart copy, status, pairing, and QR layout.