fix(ci): skip PR lookup on master pushes - #916
Merged
Merged
Conversation
Signed-off-by: Fredrik Ahlgren <[email protected]>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Accepted text proposal
Issue or Discussion: Maintainer task on 2026-08-16.
Maintainer comment that accepted this scope: Fix the repeated master failure from
gh pr view ""once and for all.What changed
The contract-pair step now calls
gh pr viewonly forpull_requestevents. Apushtomastercompares againstsrcfl/ftw-webapp@mainwithout trying to find a pull request.Why
Master test run 31936509902 failed before any product suite ran:
The workflow used
github.event.pull_request.numberon both pull-request and push events. That field is empty on a push.Boundaries and safety
This changes one CI workflow step. It does not change runtime code, release workflows, contract files, or the paired app. Pull requests still read the live PR body so a declared
Contract-pairbranch keeps working.Open PRs touching this file were checked: #735, #736, #785, and #876. This PR only fixes the event handling that those branches will inherit when rebased.
Verification
.github/workflows/test.ymlwith Ruby YAML.EVENT_NAME=push: it selectedsrcfl/ftw-webapp@mainwithout a PR lookup.EVENT_NAME=pull_requestand PR chore(ci): bump actions/setup-python from 6 to 7 #785: it read the PR and selectedsrcfl/ftw-webapp@main.git diff --check.Checklist