feat(zap): treat Zap as the P1/HAN meter only - #908
Conversation
Zap must not be a proxy for inverters, batteries or chargers. Setup and Settings now say that, and the tests expect meter-only telemetry. The bundled driver pin still points at the old zap.lua until device-drivers zap/p1-han-meter-only is pushed and the pin moves. BREAKING CHANGE: sites that ingested PV, battery or V2X through Zap lose that path. Add those devices with their own FTW drivers.
Move the device-drivers pin to 4fb8608 (#82) so the offline recovery copy of zap.lua is the meter-only driver.
![chatgpt-codex-connector[bot]](https://avatars.githubusercontent.com/in/1144995?s=60&v=4){kind=small}
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: ead8058dae
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
| ], | ||
| "repository": "srcfl/device-drivers", | ||
| "commit": "cf8894c7e17997315e21aa126cab3c7a37d224a1", | ||
| "commit": "4fb8608b9835c674e9445a747eea485d77470a64", |
There was a problem hiding this comment.
On a site that previously activated signed Zap 2.x, changing only this bundled pin does not change the running driver: ResolveDriverPaths prefers ManagedDriversDirOverride over the bundled recovery snapshot (go/internal/config/config.go:1297-1327), while repository refresh explicitly never activates a newer version (go/internal/driverrepo/manager.go:51-52). That site therefore continues emitting Zap PV, battery, and V2X data; if the operator follows the new guidance and adds native drivers, those resources are double-counted. Add an upgrade/deactivation path or enforce the P1-only behavior so a pre-3.0 managed Zap cannot shadow this bundle.
AGENTS.md reference: AGENTS.md:L12-L18
Useful? React with 👍 / 👎.
1 participant
Summary
srcfl/device-drivers@4fb8608(#82), which iszap3.0.0.People have been adding an inverter to Zap and then using the Zap integration here as the data path. That is unnecessary and not recommended.
Breaking
Sites that ingested PV, battery or V2X through Zap lose that telemetry until they add the native driver.
Test plan
go test ./internal/drivers -run 'Zap|zap|CatalogSourceful'node --test web/setup.test.mjsmake verify(pre-commit)Depends on srcfl/device-drivers#82 (merged).