fix(build) :: import 3rd party frontend assets from a list - #1456
Conversation
lovasoa
left a comment
There was a problem hiding this comment.
Hi! Can you please organize the PRs so that all are small enough to be reviewed, yet none breaks the project?
|
It looks like the next pr contains changes unrelated to what you are doing here. I think you could make a good no-brainer pr with net negative lines of code by keeping the exact exact same output files, but removing the include comment mechanism, hardcoding the concatenation logic in build.rs and copying from node modules instead of the web. |
Before assets were build by scanning for `/* !include https://... */` comments to fetch the asset from a CDN. Now the assets are a list in `build.rs`. This ends up fixing another bug where `DOC_RS` would return in the middle of a scan on the first include which would leave the gzip stream unfinished.
13078ea to
fbe2dd6
Compare
|
I originally chose not to do it that way because it required refactoring Pushed up a new stack tho. |
Before assets were build by scanning for
/* !include https://... */comments to fetch the asset from a CDN.Now the assets are a list in
build.rs.This ends up fixing another bug where
DOC_RSwould return in the middle of a scan on the first include which would leave the gzip stream unfinished.Stack created with GitHub Stacks CLI • Give Feedback 💬