Refactor Playwright component tests around SQL fixtures - #1410
Merged
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
fixtures/<suite>/{index.sql,test.ts}applications rendered through SQLPage instead of injecting synthetic DOM or calling private initializersCONTRIBUTING.mdandAGENTS.mdbaseURLvalues for the remaining official-site smoke testsWhy
This follows Playwright's recommendations to test user-visible behavior, isolate tests, use locators and web-first assertions, and avoid timing-based waits. It also exercises SQLPage's real SQL-to-template-to-initialization path, so component tests cannot silently drift from production markup.
The diff is +42 lines overall. The small increase buys explicit SQL applications, server configuration, automatic health/error checks, and contributor documentation; the chart suite itself is shorter, and the map suite replaces a fixed 500 ms sleep with deterministic outcome waits.
Validation
npm run formatnpm testnpm run testintests/end-to-end(70 passed)CI=1 npx playwright test --project=fixtures --reporter=line(40 passed, one worker)actionlintwas unavailable locally.