Fix installer telemetry silently dropped by TLS 1.0 handshake failure - #972
Merged
Conversation
The installer custom actions stopped sending telemetry when the Application Insights ingestion endpoint dropped support for TLS 1.0 and 1.1. The custom action runs inside the native SfxCA host with no managed entry assembly, so the CLR applies the .NET Framework 4.0 compatibility quirks regardless of the assembly target framework and ServicePointManager.SecurityProtocol defaults to SSL 3.0 and TLS 1.0 only. The endpoint closes the connection during the handshake, the SDK catches the exception inside InMemoryTransmitter and reports it only through its own EventSource, and Flush() returns cleanly: the MSI log showed TrackEvent as executed while no event was ever delivered. Helpers now enables TLS 1.2 before creating the TelemetryClient. Bravo.Installer.Wix.CA.dll in installer/wix/src/assets is rebuilt from these sources.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The installer custom actions stopped sending telemetry when the Application Insights ingestion endpoint dropped support for TLS 1.0 and 1.1. The custom action runs inside the native SfxCA host with no managed entry assembly, so the CLR applies the .NET Framework 4.0 compatibility quirks regardless of the assembly target framework and ServicePointManager.SecurityProtocol defaults to SSL 3.0 and TLS 1.0 only. The endpoint closes the connection during the handshake, the SDK catches the exception inside InMemoryTransmitter and reports it only through its own EventSource, and Flush() returns cleanly: the MSI log showed TrackEvent as executed while no event was ever delivered.
Helpers now enables TLS 1.2 before creating the TelemetryClient.
Bravo.Installer.Wix.CA.dll in installer/wix/src/assets is rebuilt from these sources.