feat(config): allow editing spotify launch flags - #3905
Conversation
|
No actionable comments were generated in the recent review. 🎉 ℹ️ Recent review info⚙️ Run configurationConfiguration used: Path: .coderabbit.yaml Review profile: CHILL Plan: Pro Plus Run ID: 📒 Files selected for processing (2)
📝 WalkthroughWalkthroughThe CLI recognizes ChangesCLI launch flag handling
Estimated code review effort: 2 (Simple) | ~10 minutes Mergeability Score: ⚪ Minimal · up to The change is localized to CLI argument handling and configuration updates for Spotify launch flags, with the documented checks reported as passing; no actionable merge-blocking risk remains. Possibly related PRs
🚥 Pre-merge checks | ✅ 5✅ Passed checks (5 passed)
✨ Finishing Touches🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
|
@coderabbitai review |
✅ Action performedReview finished.
|
Summary
--as the standard end-of-options separatorspicetify configto updatespotify_launch_flagsWhy
spotify_launch_flagsis displayed by the config command and consumed whenever Spicetify starts Spotify, butEditConfigintentionally ignored attempts to update it. Values normally begin with-, so the existing argument parser classified them as Spicetify flags before the config command could read them.Using the conventional
--separator keeps existing parsing unchanged while allowing the value to reach the existing string-setting path:spicetify config spotify_launch_flags -- "--flag-1|--flag-2"Testing
go test ./...go vet ./...go buildnode scripts/build-wrapper.mjs --checkSummary by CodeRabbit
New Features
--to mark the end of command-line flags, allowing dash-prefixed command values.spotify_launch_flagseditable through configuration settings.Documentation
--separator behavior.