Skip to content

feat(config): allow editing spotify launch flags - #3905

Open
abhinavgulisetty wants to merge 1 commit into
spicetify:mainfrom
abhinavgulisetty:agent/edit-spotify-launch-flags
Open

feat(config): allow editing spotify launch flags#3905
abhinavgulisetty wants to merge 1 commit into
spicetify:mainfrom
abhinavgulisetty:agent/edit-spotify-launch-flags

Conversation

@abhinavgulisetty

@abhinavgulisetty abhinavgulisetty commented Aug 13, 2026

Copy link
Copy Markdown

Summary

  • recognize -- as the standard end-of-options separator
  • allow spicetify config to update spotify_launch_flags
  • document the CLI syntax in the general and config help output

Why

spotify_launch_flags is displayed by the config command and consumed whenever Spicetify starts Spotify, but EditConfig intentionally ignored attempts to update it. Values normally begin with -, so the existing argument parser classified them as Spicetify flags before the config command could read them.

Using the conventional -- separator keeps existing parsing unchanged while allowing the value to reach the existing string-setting path:

spicetify config spotify_launch_flags -- "--flag-1|--flag-2"

Testing

  • go test ./...
  • go vet ./...
  • go build
  • node scripts/build-wrapper.mjs --check
  • isolated CLI check confirming a pipe-separated flag value is saved and read back unchanged

Summary by CodeRabbit

  • New Features

    • Added support for -- to mark the end of command-line flags, allowing dash-prefixed command values.
    • Made spotify_launch_flags editable through configuration settings.
    • Added usage guidance and an example for configuring Spotify launch flags.
  • Documentation

    • Updated command-line help to explain the -- separator behavior.

@coderabbitai

coderabbitai Bot commented Aug 13, 2026

Copy link
Copy Markdown

Review Change Stack

No actionable comments were generated in the recent review. 🎉

ℹ️ Recent review info
⚙️ Run configuration

Configuration used: Path: .coderabbit.yaml

Review profile: CHILL

Plan: Pro Plus

Run ID: 845b2ef1-f044-4cdd-866c-fc5b1d0746f5

📥 Commits

Reviewing files that changed from the base of the PR and between c9571cd and 9d76085.

📒 Files selected for processing (2)
  • spicetify.go
  • src/cmd/config.go

📝 Walkthrough

Walkthrough

The CLI recognizes -- as the end of flag parsing. Subsequent dash-prefixed arguments remain command values. Help text documents this behavior, and spotify_launch_flags is now editable through EditConfig.

Changes

CLI launch flag handling

Layer / File(s) Summary
Argument termination and usage guidance
spicetify.go
Argument parsing stops at --. Help text documents the terminator and shows how to use it with spotify_launch_flags.
Editable launch flag configuration
src/cmd/config.go
spotify_launch_flags is added to the editable string configuration fields.

Estimated code review effort: 2 (Simple) | ~10 minutes

Mergeability Score: ⚪ Minimal · up to 9d760

The change is localized to CLI argument handling and configuration updates for Spotify launch flags, with the documented checks reported as passing; no actionable merge-blocking risk remains.

Possibly related PRs

🚥 Pre-merge checks | ✅ 5
✅ Passed checks (5 passed)
Check name Status Explanation
Docstring Coverage ✅ Passed No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.
Linked Issues check ✅ Passed Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check ✅ Passed Check skipped because no linked issues were found for this pull request.
Description Check ✅ Passed Check skipped - CodeRabbit’s high-level summary is enabled.
Title check ✅ Passed The title clearly and concisely describes the main change: enabling editing of spotify launch flags through configuration.
✨ Finishing Touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands.

@abhinavgulisetty

Copy link
Copy Markdown
Author

@coderabbitai review

@coderabbitai

coderabbitai Bot commented Aug 13, 2026

Copy link
Copy Markdown
✅ Action performed

Review finished.

Note: CodeRabbit is an incremental review system and does not re-review already reviewed commits. This command is applicable only when automatic reviews are paused.

@abhinavgulisetty
abhinavgulisetty marked this pull request as ready for review August 14, 2026 06:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant