Skip to content

v0.1.12: use one visible brand mark and favicon across themes - #7

Merged
sparshsam merged 1 commit into
mainfrom
fix/single-brand-mark
Oct 22, 2026
Merged

sparshsam merged 1 commit into
mainfrom
fix/single-brand-mark

Conversation

@sparshsam

Copy link
Copy Markdown
Owner

Summary

The header brand mark and favicons now use the light artwork in both interface themes.

  • themeAssets.ts returns icon-192.png and favicon-*.png for either theme.
  • Every HTML shell preloads the light favicons, and the inline pre-hydration script no longer substitutes a -dark variant.
  • ThemeProvider keeps the same paths on theme changes. theme-color still follows the theme.
  • The near-black *-dark.png variants remain generated and shipped for application icons and social cards, but are no longer used in the interface.

Why

The dark artwork rendered on the light page (via the old cross-assignment) was barely visible. Using one visible mark removes the problem in both directions.

Verification

npm run check          ✓  329 tests across 26 files
npm run format:check   ✓
build                  ✓
  • Built HTML contains only /favicon-16.png and /favicon-32.png.
  • The built bundle references only icon-192.png.
  • Tests now assert the same mark and favicon under light, dark, and system-dark themes.
  • Docs updated: docs/branding.md, docs/interface.md, ARCHITECTURE.md, README.md, CHANGELOG.md, CLAUDE.md, AGENTS.md. Version 0.1.12.

🤖 Generated with Claude Code

The near-black *-dark.png artwork was hard to read on the light
interface. The header mark and favicons now use the light artwork in
both themes.

- themeAssets returns icon-192.png and favicon-*.png for either theme
- index/about/privacy/terms shells preload the light favicons and the
  pre-hydration script no longer substitutes a theme variant
- ThemeProvider keeps the same paths when the theme changes
- Update theme, favicon, and public-shell tests
- Update branding docs, interface docs, architecture, README, CHANGELOG,
  CLAUDE.md, and AGENTS.md; version 0.1.12

The dark variants remain generated for app icons and social cards.

Co-Authored-By: Claude Code <[email protected]>
@vercel

vercel Bot commented Oct 22, 2026 •

Copy link
Copy Markdown

The latest updates on your projects. Learn more about Vercel for GitHub.

Project Deployment Actions Updated
openresume Ready Ready Preview Oct 22, 2026 12:17am UTC

@sparshsam
sparshsam merged commit 728bdd0 into main Oct 22, 2026
3 checks passed
@sparshsam
sparshsam deleted the fix/single-brand-mark branch October 22, 2026 00:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant