Repository navigation
fix: load the combined Application Kit example - #4
Merged
Merged
Conversation
PrepareScreen selected the standalone cover letter sample for every non-resume kind. Load Example now selects explicitly by PrepareKind, and the AI template and preparation screen share one canonical combined sample so they cannot drift. Co-Authored-By: Claude Code <[email protected]>
Co-Authored-By: Claude Code <[email protected]>
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Fixes Load Example on the Application Kit preparation screen. It previously fell into the cover letter branch (
isResume ? resume : coverLetter) and inserted the standalone cover letter sample, which the combined parser rejected because both delimiters were missing.Load Example now selects explicitly by
PrepareKind. The Application Kit inserts a canonical combined sample that shares the same fictional applicant, contact details, and realistic content across both sections.The AI instructions and Load Example now share one source,
src/lib/applicationKitSample.ts, removing the duplicated kit examples that could drift.Type of change
Checklist
<type>/<description>..envfiles are included.npm run checkpasses.Verification
npm run format:check,npm run lint,npm run typecheck,npm test(279 tests across 22 files), andnpm run buildall pass.🤖 Generated with Claude Code