Skip to content

fix: load the combined Application Kit example - #4

Merged
sparshsam merged 2 commits into
mainfrom
fix/application-kit-load-example
Oct 21, 2026
Merged

sparshsam merged 2 commits into
mainfrom
fix/application-kit-load-example

Conversation

@sparshsam

Copy link
Copy Markdown
Owner

Summary

Fixes Load Example on the Application Kit preparation screen. It previously fell into the cover letter branch (isResume ? resume : coverLetter) and inserted the standalone cover letter sample, which the combined parser rejected because both delimiters were missing.

Load Example now selects explicitly by PrepareKind. The Application Kit inserts a canonical combined sample that shares the same fictional applicant, contact details, and realistic content across both sections.

The AI instructions and Load Example now share one source, src/lib/applicationKitSample.ts, removing the duplicated kit examples that could drift.

Type of change

  • Bug fix
  • Feature
  • Refactor
  • Documentation
  • Chore / tooling / dependencies

Checklist

  • Branch follows <type>/<description>.
  • No secrets, tokens, credentials, or .env files are included.
  • npm run check passes.
  • Tests cover the change (parser, pagination, layout, exports where relevant).
  • CHANGELOG updated for user-visible changes.
  • README or docs updated if behavior changed.
  • No new runtime dependency without justification.
  • No network calls, telemetry, or document storage; only the theme preference may persist.

Verification

  • npm run format:check, npm run lint, npm run typecheck, npm test (279 tests across 22 files), and npm run build all pass.
  • New regression tests cover resume, cover letter, and Application Kit Load Example; both delimiters; successful combined parsing; both applicant names; both documents' content; building into the kit workspace with no alert; and no network request or document persistence.
  • Existing standalone workflows and export tests remain green. Export engines and document designs are unchanged.
  • Corrected the stale README limitation claiming the app icon is a placeholder.

🤖 Generated with Claude Code

sparshsam and others added 2 commits October 20, 2026 21:50
PrepareScreen selected the standalone cover letter sample for every
non-resume kind. Load Example now selects explicitly by PrepareKind,
and the AI template and preparation screen share one canonical
combined sample so they cannot drift.

Co-Authored-By: Claude Code <[email protected]>
Co-Authored-By: Claude Code <[email protected]>
@vercel

vercel Bot commented Oct 21, 2026 •

Copy link
Copy Markdown

The latest updates on your projects. Learn more about Vercel for GitHub.

Project Deployment Actions Updated
openresume Ready Ready Preview Oct 21, 2026 1:51am UTC

@sparshsam
sparshsam merged commit 2b0ddae into main Oct 21, 2026
3 checks passed
@sparshsam
sparshsam deleted the fix/application-kit-load-example branch October 21, 2026 01:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant