Skip to content

Fix clippy issues #5

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
amirylm merged 1 commit into from
Oct 28, 2025
Merged

Fix clippy issues #5

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
14 changes: 7 additions & 7 deletions src/xor_dist.rs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -29,6 +29,8 @@ impl Ord for HeapEntry {

/// Implement PartialOrd for HeapEntry to allow comparisons between entries based on their distance.
/// It does not need to reverse the comparison since Ord already does that.
/// Clippy warning is suppressed because this is intentional for use with BinaryHeap.
#[allow(clippy::non_canonical_partial_ord_impl)]
impl PartialOrd for HeapEntry {
fn partial_cmp(&self, other: &Self) -> Option<Ordering> {
Some(self.distance.cmp(&other.distance))
Expand Down Expand Up @@ -117,16 +119,14 @@ where

if max_heap.len() < n {
max_heap.push(entry);
} else {
} else if let Some(top_entry) = max_heap.peek()
&& entry.distance < top_entry.distance
{
// Check if the current entry's distance is smaller than the largest distance
// currently in the heap (which is the root of the max-heap).
// If it is, we pop the largest (furthest) entry and push the new one.
if let Some(top_entry) = max_heap.peek() {
if entry.distance < top_entry.distance {
max_heap.pop();
max_heap.push(entry);
}
}
max_heap.pop();
max_heap.push(entry);
}
}

Expand Down