Repository navigation
feat(gateway): serve cTRNG only when explicitly enabled - #147
Merged
Merged
Conversation
nicolasriverocorvalan
requested review from
DaniDeltaT,
amirylm and
rezabfil-sec
as code owners
September 18, 2026 23:46
amirylm
approved these changes
Sep 19, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
cTRNG is now off by default. Deployments that serve KMS only no longer run the masterseed plugin, so the gateway must start without it:
ORBITPORT_MASTERSEED_PLUGINbecame optional and is only required whenORBITPORT_CTRNG_ENABLED=truewith the flag off,
/api/v1/services/*is not registered (404 before auth, no credit hold) andctrng.Getreturns "cTRNG feature disabled". No cTRNG code is removedalso reorders the RPC route to match path before method, so an unknown path answers 404 instead of the 405 warp returns when the method filter rejects first
both compose stacks set the flag to true, so local dev and the Go beacon e2e tests are unchanged
Validation
cargo fmt -- --checkcargo clippy --all-targets -- -D warningscargo test -- --skip test_e2edocker compose configon both compose filesv0.2.20-rc-2:1. gateway starts with
ctrng_enabled: false, masterseed_plugin: Noneand waits only on auth, kms, account and patissuer;2.
/api/v1/services/trng404; GET/api/v1/rpc405;ctrng.Getreturns "cTRNG feature disabled";3.
kms.GetCapabilitiesand a key-store Put/Get/Delete round trip behave normally