Repository navigation
Lean on SDK defaults and align env var naming - #1
Merged
Merged
Conversation
The SDK already defaults apiUrl/authDomain/audience to prod and skips Description/Tags on the wire when omitted, so the explicit values were redundant. Renames OP_CLIENT_ID/ OP_CLIENT_SECRET to ORBITPORT_CLIENT_ID/ORBITPORT_CLIENT_SECRET to match the SDK's own examples and tests. Drops the lazy-init proxy: passing undefined credentials is now constructor-safe, so the build no longer needs protection from eager validation. The op-dev probe script goes away with the rest of the dev-gateway plumbing.
amirylm
approved these changes
May 6, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
apiUrl/authDomain/audiencefrom the SDK init — the SDK already defaults them tohttps://op.spacecomputer.io,auth.spacecomputer.io, andhttps://op.spacecomputer.io/api.description: ""andtags: []fromkms.createKey— the SDK omits both fields from the wire when undefined; passing empty values actively sentDescription: ""/Tags: [].OP_CLIENT_ID/OP_CLIENT_SECRET→ORBITPORT_CLIENT_ID/ORBITPORT_CLIENT_SECRETto match the convention used in the SDK's own examples and tests (per the upcoming auth how-to in docs#15).src/lib/server/orbitport.ts: withundefinedcreds, the SDK constructor no longer throws, so build-time eager-validation protection is unnecessary.scripts/probe-sign.tsand theOP_BASE_URL/OP_AUTH_*/OP_DEBUGenv knobs — debug helpers for the op-dev gateway, no longer needed now that we target prod exclusively.Test plan
bun run build— typecheck + Next build passbun run devand walk the four-step flow on Sepolia with realORBITPORT_*credentials (create key → fund → deploy Counter → increment)