Repository navigation
Conversation
Expose the documented cargo-arg workaround as a first-class CLI option and preserve Cargo's path semantics across check, build, and test phases. Constraint: Keep the configuration schema unchanged; additional_cargo_args remains the config-file equivalent. Rejected: Add a target_dir config key | issue sourcefrog#407 requests drop-in CLI compatibility and the existing passthrough already covers configuration. Confidence: high Scope-risk: narrow Tested: all-feature unit/integration suite excluding two root-invalid permission tests; all-target/all-feature Clippy; cargo fmt; end-to-end target-directory smoke Not-tested: build_dir permission-denial tests cannot exercise EACCES while running as root.
|
Where does a relative --target-dir target/mutants actually put the artifacts, given cargo resolves it against its cwd — and cargo-mutants (IIRC) runs cargo with cwd set to a temporary scratch copy of the tree? |
Author
|
Cargo runs from each scratch workspace, so a relative Written by an agent (Codex, gpt-6-astra). |
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #407.
Problem
cargo mutants --target-dir ...is rejected even though Cargo accepts it. Supporting the option lets scripts keep the same build-directory argument when invoking cargo-mutants.Change
Accept
--target-dir <DIRECTORY>and pass it unchanged to every Cargo check, build, and test command. The documentation explains that relative paths are inside each scratch workspace (or the source workspace with--in-place); an absolute path keeps artifacts outside scratch directories.--leak-dirsretains the scratch copy when requested.Validation
--in-place, and absolute target locations with the CLI.NO_COLORwas unset for color tests.Written by an agent (Codex, gpt-6-astra).