manage-config: guard secureboot config append - #605
Open
arista-hpandya wants to merge 1 commit into
Open
Conversation
|
/azp run |
|
Azure Pipelines: There may be pipelines that require an authorized user to comment /azp run to run. |
|
Azure Pipelines: Successfully started running 1 pipeline(s). |
Add a newline before appending the secureboot config so fragments cannot be concatenated when config.sonic lacks a trailing newline. Also factor the config paths into variables for reuse. Signed-off-by: arista-hpandya <[email protected]>
arista-hpandya
force-pushed
the
handle-no-new-lines-in-manage-config
branch
from
August 5, 2026 05:09
5cc5e14 to
257b8bc
Compare
|
/azp run |
|
Azure Pipelines: Successfully started running 1 pipeline(s). |
Contributor
|
Does the file not currently contain a trailing newline? IMO, this is something that should be fixed in the actual sources, not worked around. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Add a newline before appending the secureboot config so fragments cannot be concatenated when config.sonic lacks a trailing newline. Also factor the config paths into variables for reuse.