Skip to content

test: address parser limit review feedback - #2

Open
GeorgMelinius wants to merge 1 commit into
sondt99:fix-parser-dosfrom
GeorgMelinius:fix-pr148-review-feedback
Open

test: address parser limit review feedback#2
GeorgMelinius wants to merge 1 commit into
sondt99:fix-parser-dosfrom
GeorgMelinius:fix-pr148-review-feedback

Conversation

@GeorgMelinius

Copy link
Copy Markdown

Addresses all three unresolved Cubic findings on firecrawl#148:

  • document that selected safety caps degrade gracefully instead of always returning ResourceLimit
  • build the 200,000-level PPT regression fixture in linear time with one allocation
  • use the unstarred RTF mmath destination so the test exercises MathState::open_group

Verified with Rust 1.88:

  • cargo fmt --all --check
  • cargo clippy --workspace --all-targets --all-features -- -D warnings
  • cargo test --locked (290 unit tests, robustness test, and 9 snapshot tests passed; 1 local-samples test ignored)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants