Skip to content

fix(statistics): stale-while-revalidating skeleton + accessible trend… - #1450

Open
charityagbenu12-cmd wants to merge 1 commit into
solutions-plug:mainfrom
charityagbenu12-cmd:somzilla_1352-1355
Open

fix(statistics): stale-while-revalidating skeleton + accessible trend…#1450
charityagbenu12-cmd wants to merge 1 commit into
solutions-plug:mainfrom
charityagbenu12-cmd:somzilla_1352-1355

Conversation

@charityagbenu12-cmd

Copy link
Copy Markdown

This PR

Closes #1352
Closes #1353
Closes #1354
Closes #1355

  • Migrate useAsync consumers to the status/retry contract (statistics, markets, market detail, dispute); auto-retry backoff 2^attempt * 500 (1s/2s/4s, 3 retries)

  • Keep statistics widgets visible during background refreshes (showSkeleton = loading && !data) so stale data persists while revalidating

  • Add dependency-free accessible VolumeChart (role=img, title, aria-expanded/aria-controls, real table fallback) wired into the statistics dashboard trends section

  • Update useAsync, Statistics, and VolumeChart tests for the new contract

Description

Type of Change

  • Bug fix
  • New feature
  • Refactor / code cleanup
  • Documentation update
  • CI / tooling change
  • Breaking change

Testing Done

Bundle Size

Chunk Before After
vendor.js
main*.js
pages/_app*.js

Checklist

  • Tests pass locally
  • Documentation updated (if applicable)
  • No breaking changes, or breaking changes are documented above
  • If you added or changed an API endpoint, regenerated the OpenAPI spec and committed the result:
    cd services/api && cargo run --bin generate-openapi > openapi.yaml
    git add openapi.yaml && git commit -m "chore: regenerate openapi.yaml"
  • If you changed system architecture (new service, database, external dependency, or network boundary), updated docs/architecture.md
  • Bundle size checked (if frontend change

… charts (solutions-plug#1353, solutions-plug#1354)

- Migrate useAsync consumers to the status/retry contract (statistics, markets, market detail, dispute); auto-retry backoff 2^attempt * 500 (1s/2s/4s, 3 retries)

- Keep statistics widgets visible during background refreshes (showSkeleton = loading && !data) so stale data persists while revalidating

- Add dependency-free accessible VolumeChart (role=img, title, aria-expanded/aria-controls, real table fallback) wired into the statistics dashboard trends section

- Update useAsync, Statistics, and VolumeChart tests for the new contract
@drips-wave

drips-wave Bot commented Aug 29, 2026

Copy link
Copy Markdown

@charityagbenu12-cmd Great news! 🎉 Based on an automated assessment of this PR, the linked Wave issue(s) no longer count against your application limits.

You can now already apply to more issues while waiting for a review of this PR. Keep up the great work! 🚀

Learn more about application limits

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

1 participant