Repository navigation
reconcile sets the controller default mod pack to the desired pack - #426
Merged
Merged
Conversation
…o the web UI's default-pack icons follow the pack the servers run
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
reconcile.mjsnow also pointscontroller.default_mod_pack_idat the desired mod pack. Before, it created each new pack and moved the instances onto it but left the controller default on whatever it was. On pve7 that is Clusterio's stock "Space Age 2.1" pack, which has no exported icons, so the web map drew planets as "?".<id of new pack>).defaultModPack: false, or namescontroller.default_mod_pack_idin itscontrollerblock (an explicit value wins).produces:line mention the default pack.Checks:
node --test tests/tools/reconcile.test.mjs: 16 pass, 0 fail (new: default follows the desired pack without a restart, the opt-out and an explicit value; the missing-pack plan and the apply test resolve the new pack's id for the default).plan --cluster vmwith this candidate listscontroller controller.default_mod_pack_id -> "Space Age 2.1.22 - Surface Export 0.7.11"as the last action. Not applied: that plan also carries the 2.1.22 move for pve7 from Factorio 2.1.22 with maraxsis 1.39.22, PlanetsLib 2.0.10, FluidMustFlow 1.5.1 and SpidertronPatrols 2.7.1 #425.