Refactoring of DiscreteGridField and add ScalarFieldMapping - #3
Open
damienmarchal wants to merge 6 commits into
Open
damienmarchal wants to merge 6 commits into
damienmarchal wants to merge 6 commits into
Conversation
The sampling is now done in component called GridSampler while the DiscreteGridField is there just to do the tri linear interpolation.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
DiscreteGridField is a component made a long time ago to cut dependencies between SofaImplicitField & SofaDistanceGrid.
The current implementation has defects, one of them is that the component can only load the grid content from a MHD file. So i refactor it to become a component with the sole purpose of storing a grid and doing field/grad/hessian evaluation and delegating to other component the content generation (from a file, from a field: see example-grid-generation-from-field.py). I also added experiment on using the grid that results in a mapping (see example scalar-field-mapping.py)
The PR: