Skip to content

fix: bump certifi to >=2026.10.19 for Snyk security vulnerability - #519

Merged
hemang-snyk merged 2 commits into
mainfrom
cursor/snyk-fix-2026-10-21-cbcb
Oct 21, 2026
Merged

hemang-snyk merged 2 commits into
mainfrom
cursor/snyk-fix-2026-10-21-cbcb

Conversation

@cursor

@cursor cursor Bot commented Oct 21, 2026 •

Copy link
Copy Markdown

Bump certifi override in pyproject.toml to >=2026.10.19 (resolved 2026.10.19) to fix 1 critical vulnerability identified by Snyk:

  • SNYK-PYTHON-CERTIFI-21280764 (Critical): Improper Certificate Validation

Verified that agent_scan package builds and imports successfully, and snyk test passes clean with 0 issues.

Open in Web View Automation 

Note

Low Risk
Dependency-only security bump with no runtime logic changes; risk is limited to TLS/CA trust behavior from the updated certifi release.

Overview
Pins certifi to >=2026.10.19 as a direct project dependency and refreshes uv.lock so the resolved bundle moves from 2026.1.4 to 2026.10.19, addressing Snyk’s SNYK-PYTHON-CERTIFI-21280764 (improper certificate validation).

No application code changes—only dependency metadata and the lockfile so installs consistently pull the patched CA bundle used by TLS clients (e.g. aiohttp).

Reviewed by Cursor Bugbot for commit 3a85cc2. Bugbot is set up for automated code reviews on this repo. Configure here.

@hemang-snyk
hemang-snyk marked this pull request as ready for review October 21, 2026 07:39
@hemang-snyk
hemang-snyk requested review from a team and marcelosousa as code owners October 21, 2026 07:39
@qodo-merge-etso

Copy link
Copy Markdown

PR Summary by Qodo

Raise the certifi minimum version to address a Snyk vulnerability

🐞 Bug fix ⚙️ Configuration changes 🕐 Less than 10 minutes

Grey Divider

AI Description

• Require certifi 2026.10.19 or newer through uv's transitive dependency overrides.
• Address the critical improper certificate validation vulnerability reported by Snyk.
High-Level Assessment

The existing uv override list is the appropriate place to constrain this transitive dependency; adding certifi as a direct project dependency would imply that the application uses it directly.

Files changed (1) +1 / -0

Bug fix (1) +1 / -0
pyproject.tomlSet a secure minimum version for certifi +1/-0

Set a secure minimum version for certifi

• Adds 'certifi>=2026.10.19' to uv's transitive dependency overrides to address the reported certificate validation vulnerability.

pyproject.toml

@qodo-merge-etso

qodo-merge-etso Bot commented Oct 21, 2026 •

Copy link
Copy Markdown

Code Review by Qodo

🐞 Bugs (0) 📘 Rule violations (0) 🔗 Cross-repo conflicts (0) 📜 Skill insights (0)

Grey Divider


Action required

1. Published scans can use vulnerable certs ✓ Resolved
Description
certifi>=2026.10.19 is added only to uv's override list, so the built wheel does not declare that
minimum version. When a published install resolves an older certifi through its transitive
dependencies or constraints, the scanner still uses that certificate bundle for backend connections.
Code

pyproject.toml[43]

+    "certifi>=2026.10.19",
Relevance

●●● Strong

Published wheels ignore uv overrides, so the security fix must constrain certifi for downstream
consumers.

PR-#500
PR-#506

ⓘ Recommendations generated based on similar findings in past PRs

Evidence
The published dependency list does not include certifi, while the new floor is in uv-only
configuration. The repository builds and publishes a wheel, documents installing it with uvx, and
uses certifi's bundle for its shared backend connector.

pyproject.toml[14-27]
pyproject.toml[33-44]
Makefile[62-71]
README.md[106-118]
src/agent_scan/verify_api.py[458-488]

Agent prompt
The issue below was found during a code review. Follow the provided context and guidance below and implement a solution

## Issue description
The certifi floor is only a uv override and is absent from published wheel requirements, leaving installs free to use an older certificate bundle.
## Fix Focus Areas
- pyproject.toml[14-27]
- pyproject.toml[36-44]
## Recommended Fix
Add `certifi>=2026.10.19` to `[project].dependencies` so wheel consumers receive the minimum version requirement; remove the redundant override if appropriate.

ⓘ Copy this prompt and use it to remediate the issue with your preferred AI generation tools


Grey Divider

Context sources
❌ Tickets: failed to load — Ticket collection could not establish complete evidence
✅ Compliance rules (platform): 6 rules
✅ Cross-repo context — repo relationships
Review mode: Auto: ⚖️ Balanced: Security-sensitive dependency override warrants careful review despite its localized one-line change.

Grey Divider

Tip of the day
💡 Did you know, you can start a comment with 'qodo' or '@qodo' to chat about any finding

More tips ↗ | Customize Qodo ↗ | Qodo docs ↗

Grey Divider

Qodo Logo

Comment thread pyproject.toml Outdated
@hemang-snyk
hemang-snyk enabled auto-merge October 21, 2026 07:50
@hemang-snyk
hemang-snyk merged commit 73c0966 into main Oct 21, 2026
11 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants