Fix build on FreeBSD/OpenBSD: ENODATA not defined in errno.h - #2968
Open
michael-o wants to merge 1 commit into
Open
Fix build on FreeBSD/OpenBSD: ENODATA not defined in errno.h#2968michael-o wants to merge 1 commit into
michael-o wants to merge 1 commit into
Conversation
ENODATA is an XSI/SVID extension and is not guaranteed by POSIX; FreeBSD and OpenBSD do not define it in errno.h, breaking the build of the vendored nanoarrow_ipc.c (nanoarrow 0.3.0) on those platforms. Add a portable fallback definition, matching the fix proposed upstream in apache/arrow-nanoarrow#906. This is a stopgap until Snowflake re-vendors a nanoarrow release containing that fix. Upstream-PR: apache/arrow-nanoarrow#906 This fixes snowflakedb#2967
|
All contributors have signed the CLA ✍️ ✅ |
Author
|
I have read the CLA Document and I hereby sign the CLA |
Author
|
recheck |
Author
|
FTR: Upstream PR has been merged. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
ENODATA is an XSI/SVID extension and is not guaranteed by POSIX; FreeBSD and OpenBSD do not define it in errno.h, breaking the build of the vendored nanoarrow_ipc.c (nanoarrow 0.3.0) on those platforms.
Add a portable fallback definition, matching the fix proposed upstream in apache/arrow-nanoarrow#906. This is a stopgap until Snowflake re-vendors a nanoarrow release containing that fix.
Upstream-PR: apache/arrow-nanoarrow#906
This fixes #2967
Please answer these questions before submitting your pull requests. Thanks!
What GitHub issue is this PR addressing? Make sure that there is an accompanying issue to your PR.
Fixes SNOW-3818968: Does not compile out of the box on FreeBSD due to \"ENODATA not defined in errno.h\" #2967
Fill out the following pre-review checklist:
Please describe how your code solves the related issue.
Makes compile and run.