Skip to content

Align install_pyenv return annotation with actual behavior - #104

Closed
smythi93 with Copilot wants to merge 2 commits into
mainfrom
copilot/fix-code-review-comment
Closed

smythi93 with Copilot wants to merge 2 commits into
mainfrom
copilot/fix-code-review-comment

Conversation

Copilot AI commented May 25, 2026 •

Copy link
Copy Markdown

The linked review comment flagged a type mismatch: install_pyenv() was annotated to return str but never returned a value.
This update applies that comment directly and limits scope to the requested change.

  • Type annotation correction

    • Updated install_pyenv signature in src/tests4py/environment.py:
      • from -> str
      • to -> None
    • No runtime logic, control flow, or call sites were changed.
  • Why this matters

    • Removes a misleading contract for callers and static analysis.
    • Keeps the function API consistent with its side-effect-only implementation.
# before
def install_pyenv() -> str:

# after
def install_pyenv() -> None:

Warning

Firewall rules blocked me from connecting to one or more addresses (expand for details)

I tried to connect to the following addresses, but was blocked by firewall rules:

  • pyenv.run
    • Triggering command: /usr/bin/curl curl REDACTED (dns block)

If you need me to access, download, or install something from one of these locations, you can either:

@smythi93
smythi93 marked this pull request as ready for review May 25, 2026 07:09
Copilot AI review requested due to automatic review settings May 25, 2026 07:09

Copilot AI left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Copilot wasn't able to review any files in this pull request.


💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

Copilot AI changed the title [WIP] Fix code based on review comment Align install_pyenv return annotation with actual behavior May 25, 2026
Copilot AI requested a review from smythi93 May 25, 2026 07:12
@smythi93 smythi93 closed this May 25, 2026
@smythi93
smythi93 deleted the copilot/fix-code-review-comment branch July 23, 2026 20:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants