Stop appending the compression buffer's unused capacity to the request body - #1342
Open
adwsingh wants to merge 1 commit into
Open
Stop appending the compression buffer's unused capacity to the request body#1342adwsingh wants to merge 1 commit into
adwsingh wants to merge 1 commit into
Conversation
adwsingh
marked this pull request as ready for review
August 30, 2026 05:04
mtdowling
approved these changes
Aug 30, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What behavior changes?
Stops appending the compression buffer's unused capacity to the request body
Why is this change needed?
Gzip.compress built the compressed body in a ByteBufferOutputStream and then handed the stream's
backing array to DataStream.ofBytes. That array is grown by doubling, so its length is the buffer's
capacity rather than the number of bytes written, and ofBytes(byte[]) wraps the whole thing: every
compressed request carried the unused capacity as trailing zeros appended to the gzip stream. For
small bodies that was 7 to 20 bytes on the wire, and only zero when the byte count happened to land
exactly on a capacity boundary. Passing the ByteBuffer instead uses the count as the limit.
How was this validated?
List tests added, benchmarks run, or manual verification performed.
What should reviewers focus on?
Point reviewers to the files or sections that contain the interesting logic.
Additional Links
Related issues, design docs, or prior art.
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.