Repository navigation
Share links: one fixed link per project, QR codes - #105
Merged
Merged
Conversation
- A project's link id is derived from its project id (SHA-256, 12 base62 characters; share::link_id in the app, linkIdFor on the server), so the Export dialog always shows the link, even before anything is uploaded. A project's earlier random-id link is replaced by it on the next share. - QR code for the link: a toggle on the link box in the app, and on the share page (small beside the actions, large on click, for a projector). - Share page: rendered page kept in the edge cache for 30 s. - Export dialog: link box text centred, step contents aligned with step names, link shown while uploading instead of the "Done closes this" note. - "Your links" list removed from the Export dialog.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
share::link_idin the app,linkIdForin thesharefunction), so Export always shows the project's link, even before anything is uploaded. A project's earlier random-id link is replaced on its next share.[email protected]from jsdelivr with an SRI hash.The
sharefunction changes are already deployed.Tests:
cargo test --workspace; liveshare_again_keeps_the_link(same link on re-share, derived id, new video served).