Repository navigation
fix(cubejs): every datasource form connects; compile errors arrive one by one - #104
Merged
Merged
Conversation
acmeguy
force-pushed
the
fix/datasource-forms
branch
2 times, most recently
from
October 31, 2026 13:01
f54963d to
959a28c
Compare
…e by one Datasource types the UI offers but that could never connect: - Presto / Trino: the form's password (`pass`) was never read; presto-client authenticates only with basic_auth. - SQL Server: the SSL checkbox was ignored (the driver reads options.encrypt), so encrypted-only servers (Azure SQL) never connected. - Hive: the generic form writes user/database; the driver reads username/dbName. - Firebolt: the driver read its login from server env first and crashed when there was none, and the datasource's connection lacked the auth shape and account the driver uses. Patched the env read; mapped the form onto connection.auth (email login or service-account id/secret) + account. - DuckDB: the MotherDuck token went to motherduck_token; the driver reads motherDuckToken. Compile errors: validate, validate-in-branch, reconcile-team and the smart-gen model validator read compiler.errorsReport, which Cube renamed errorsReporter (gone since at least 1.7.30), so every structured error was lost and callers got one thrown blob. 747/747 in the image. Co-Authored-By: Claude Opus 5.5 <[email protected]>
acmeguy
force-pushed
the
fix/datasource-forms
branch
from
October 31, 2026 13:39
959a28c to
33966ce
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Stacked on #103. Found while making sure cxs2 supports every datasource type: several types the UI offers could never connect.
Datasource fixes (
prepareDbParams+ one driver patch)pass) never read; presto-client only usesbasic_authbasic_auth: { user, password }options.encrypt); Azure SQL couldn't connectoptions: { encrypt: ssl, useUTC: true }user/database; driver readsusername/dbNameconnectionlackedauth/accountmotherduck_token; driver readsmotherDuckTokenCompile errors
validate,validate-in-branch,reconcile-teamand the smart-gen model validator readcompiler.errorsReport, which Cube renamed toerrorsReporter(already gone in 1.7.30). Every structured error was lost and callers got one thrown blob; now each error arrives separately. The cxs2 save gate relies on this.Verification
yarn test747/747.CUBEJS_DB_USER;errorsReporter, witherrorsReportconfirmed undefined.🤖 Generated with Claude Code