Repository navigation
cre/sdk: add compute_duration_ms to ExecutionResult - #472
Merged
DylanTinianov merged 1 commit intoOct 13, 2026
Merged
Conversation
The module that executes a workflow reports the run's wall-clock duration on the result it returns: the WASM host times the guest run, and the confidential module carries over the enclave-reported duration. The workflow engine meters whatever is reported as cre:workflow:compute, so it no longer needs to know which module executed, or time the run itself. Presence distinguishes an unavailable measurement from a measured zero. Regenerated sdk.pb.go and the embedded proto sources with the pinned generator versions (protoc 29.3, protoc-gen-go 1.36.6). Co-Authored-By: Claude Fable 5.1 <[email protected]>
|
product-security-plaid-production
Bot
requested review from
amit-momin and
jmank88
October 13, 2026 21:13
Contributor
|
The latest Buf updates on your PR. Results from workflow Regenerate Protobuf Files / buf (pull_request).
|
jmank88
approved these changes
Oct 13, 2026
This was referenced Oct 13, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What
Adds
optional int64 compute_duration_ms = 5tosdk.v1alpha.ExecutionResult, plus the regeneratedcre/go/sdk/sdk.pb.goand embedded proto sources.Why
Compute metering (CRE-6779) needs one duration per execution that is right for both ordinary and confidential runs. The module that executes the workflow sets it on the result it already returns: the WASM host times the guest run; the confidential module carries over the enclave-reported
execution_duration_ms(#469). The engine meters what is reported and no longer needs to know which module ran, or to time the run itself.Optional field: presence distinguishes an unavailable measurement from a measured zero. Backward compatible for SDKs that build
ExecutionResult.Consumers
Same change targeting
mainas a cherry-pick per the CRE branch policy: see the companion PR.Testing
cd cre/go && go generate ./... && go build ./... && go test ./...;cd cre/verify && go run .. Regenerated with the pinned protoc 29.3 / protoc-gen-go 1.36.6, so only the three touched files change.🤖 Generated with Claude Code