fix(catalog): emit added_server_name from CLI and retire legacy AddServerModal - #1416
Merged
Merged
Conversation
…legacy AddServerModal
Deploying mcpproxy-docs with
|
| Latest commit: |
1f5a1d1
|
| Status: | ✅ Deploy successful! |
| Preview URL: | https://72f9e589.mcpproxy-docs.pages.dev |
| Branch Preview URL: | https://fix-low-1407-catalog-cli-par.mcpproxy-docs.pages.dev |
|
Codecov Report❌ Patch coverage is
📢 Thoughts on this report? Let us know! |
Contributor
📦 Build ArtifactsWorkflow Run: View Run Available Artifacts
How to DownloadOption 1: GitHub Web UI (easiest)
Option 2: GitHub CLI gh run download 36590510095 --repo smart-mcp-proxy/mcpproxy-go
|
![github-actions[bot]](https://avatars.githubusercontent.com/in/15368?s=60&v=4){kind=small}
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Finishes the remaining low-priority follow-ups from #1407 and keeps the manual-add experience consistent with the secure onboarding defaults.
mcpproxy catalog search/catalog show(JSON) emitadded_server_namewhen exactly one configured server matches, mirroring the REST resolver (source+target for registry-sourced servers, target-only for manual adds, no name when ambiguous).AddServerModal.vueand modal-only specs. The replacement Manual form exposes trust modes with Manual as the default, submits the selected mode, requires explicit confirmation for Auto, and cannot submit while that warning is unresolved. The onboarding wizard keeps its existing quarantined Manual flow.Validation: full frontend production build and Vitest suite (1,718 tests),
go build ./...from the pre-push hook, focused browser and REST checks on an isolated instance, and independent Sol review.Closes #1407