fix(catalog): restore catalog add and open flows (Spec 109-j) - #1400
Merged
Merged
Conversation
Contributor
📦 Build ArtifactsWorkflow Run: View Run Available Artifacts
How to DownloadOption 1: GitHub Web UI (easiest)
Option 2: GitHub CLI gh run download 36410525225 --repo smart-mcp-proxy/mcpproxy-go
|
|
Codecov Report✅ All modified and coverable lines are covered by tests. 📢 Thoughts on this report? Let us know! |
Deploying mcpproxy-docs with
|
| Latest commit: |
9957a8f
|
| Status: | ✅ Deploy successful! |
| Preview URL: | https://5e3b996d.mcpproxy-docs.pages.dev |
| Branch Preview URL: | https://codex-ux-catalog-regressions.mcpproxy-docs.pages.dev |
![github-actions[bot]](https://avatars.githubusercontent.com/in/15368?s=60&v=4){kind=small}
3 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What changed
Restores catalog-first Add Server and Added/Open behavior across Web, macOS, and REST, including the remaining Home, Servers, and onboarding entry points.
/add-serverwith Catalog selected; Home import routes to?tab=import; the onboarding wizard keeps manual add inline and completes without navigating away.added_server_nameonly for a unique caller-visible match. Secret controls fail closed when the keyring is unavailable, and existing credentials are not overwritten.Spec:
specs/109-ux-navigation-consistency/(FR-062–FR-065; T108). The unusedAddServerModal.vuecleanup is explicitly deferred to the follow-up issue.Verification
npm run build;npx vitest run— 202 files, 1,718 tests passed.go build ./...passed.MCPPROXY_HOME=<scratch> swift test— 1,360 tests passed.