feat(catalog): real popularity signal — GitHub stars + Docker pulls (Spec 110)

Makefile

@@ -1,6 +1,6 @@
 # MCPProxy Makefile
 
-.PHONY: help build build-server build-docker build-deb swagger swagger-verify frontend-build frontend-dev backend-dev clean test test-coverage test-e2e test-e2e-oauth lint dev-setup docs-setup docs-dev docs-build docs-clean bench-discovery
+.PHONY: help build build-server build-docker build-deb swagger swagger-verify frontend-build frontend-dev backend-dev clean test test-coverage test-e2e test-e2e-oauth test-descendant-pids test-e2e-cleanup-check lint dev-setup docs-setup docs-dev docs-build docs-clean bench-discovery
 
 SWAGGER_BIN ?= $(HOME)/go/bin/swag
 SWAGGER_OUT ?= oas
@@ -20,6 +20,8 @@ help:
 	@echo "  make test-coverage   - Run tests with coverage"
 	@echo "  make test-e2e        - Run all E2E tests"
 	@echo "  make test-e2e-oauth  - Run OAuth E2E tests with Playwright"
+	@echo "  make test-descendant-pids    - Unit test for the E2E cleanup trap's process-tree walk"
+	@echo "  make test-e2e-cleanup-check  - Integration test: E2E cleanup trap reaps only its own processes"
 	@echo "  make lint            - Run linter"
 	@echo "  make dev-setup       - Install development dependencies (swag, frontend, Playwright)"
 	@echo ""
@@ -176,6 +178,22 @@ test-e2e: test-e2e-oauth
 	@echo "🧪 Running E2E tests..."
 	./scripts/test-api-e2e.sh
 
+# Unit test for descendant_pids (scripts/descendant-pids.sh), the process-tree
+# walk the E2E cleanup trap uses to reap only what a run itself spawned.
+# Hermetic — no built binary required.
+test-descendant-pids:
+	@echo "🧪 Running descendant_pids unit test..."
+	./scripts/descendant-pids.test.sh
+
+# Integration test: proves the E2E cleanup trap reaps only what its own run
+# started (a decoy mcpproxy on another port survives) and that it actually
+# reaps a real orphan of the run (the launcher-test fixture). Requires a
+# built ./mcpproxy binary; not part of `test-e2e` since it re-runs the whole
+# E2E suite as a subprocess.
+test-e2e-cleanup-check:
+	@echo "🧪 Running E2E cleanup-trap safety check..."
+	./scripts/test-api-e2e-cleanup-check.sh
+
 # Documentation site commands
 docs-setup:
 	@echo "📦 Installing documentation dependencies..."

ROADMAP.md

@@ -1035,3 +1035,4 @@ Legend: `shipped` ≥95% checked · `in-flight` 1–94% · `drafted` 0% · `—`
 | [105-agent-scope-hardening](./specs/105-agent-scope-hardening/) | `in-flight` | 94/113 (83%) |
 | [106-security-residual-fixes](./specs/106-security-residual-fixes/) | `shipped` | 18/19 (95%) |
 | [107-server-edition-sso-hardening](./specs/107-server-edition-sso-hardening/) | `shipped` | 126/126 (100%) |
+| [110-catalog-popularity](./specs/110-catalog-popularity/) | `in-flight` | 19/23 (83%) |

cmd/generate-types/main.go

@@ -325,6 +325,25 @@ export interface IsolationDefaults {
   working_dir?: string;
 }
 
+`)
+
+	// Tier constants - generated from internal/contracts/tier.go
+	// Spec 109 FR-028/X11: one pure function (contracts.AnnotationTier)
+	// computes this everywhere — the Web/macOS/CLI surfaces never derive
+	// their own. `unknown` is returned only by the review payload composer,
+	// never by AnnotationTier itself.
+	sb.WriteString(`export const TierRead = 'read' as const;
+export const TierWrite = 'write' as const;
+export const TierDestructive = 'destructive' as const;
+export const TierUnannotated = 'unannotated' as const;
+export const TierUnknown = 'unknown' as const;
+export type Tier =
+  | typeof TierRead
+  | typeof TierWrite
+  | typeof TierDestructive
+  | typeof TierUnannotated
+  | typeof TierUnknown;
+
 `)
 
 	// Tool types
@@ -341,6 +360,9 @@ export interface IsolationDefaults {
   // Tool-level quarantine status surfaced by the same approval record.
   // Optional because non-quarantined tools simply omit the field.
   approval_status?: string;
+  // Computed by contracts.AnnotationTier (Spec 109 FR-028) — never derive
+  // this from annotations on the frontend (X11).
+  tier?: Tier;
   // Why the trust_mode: scan gate held this tool for review (spec 086
   // FR-018). held_signals names the matched deterministic check ids, e.g.
   // "tpa.TPA-2026-0001.hidden_instruction". All three are absent unless the