Skip to content

test(macos): assert tray quarantine Review row appears once #1406

Description

@Dumbris

Summary

The tray menu currently avoids showing two “Review” rows when quarantine review is already the primary action. Keep that guarantee pinned in the native test suite.

Reproduction

The new primary-item logic can return .open(.review) for a quarantined server. The tray builder then also appends its independent quarantine Review row unless primaryOpensReview is set and checked. TrayAuditMenuTests.testAQuarantinedServerOffersAReview and testAQuarantinedServerThatAlsoNeedsLoginOffersBothSignInAndReview only select the first matching item, so a duplicate would still pass.

Follow-up

  • Assert exactly one Review item when review is the primary action.
  • Assert exactly one Review item for quarantined + OAuth sign-in (Sign in primary plus one Review path).

Verified during final ZCode review of PR #1381 (low severity); current implementation is correct.

Activity

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Assignees

No one assigned

    Labels

    kind/bugSomething isn't workingpriority/lowNice to have; address when bandwidth allowstriage/acceptedTriaged and accepted for the backlog

    Type

    No type

    Projects

    No projects

      Milestone

      No milestone

      Relationships

      None yet

      Development

      No branches or pull requests

      Issue actions