Summary
The tray menu currently avoids showing two “Review” rows when quarantine review is already the primary action. Keep that guarantee pinned in the native test suite.
Reproduction
The new primary-item logic can return .open(.review) for a quarantined server. The tray builder then also appends its independent quarantine Review row unless primaryOpensReview is set and checked. TrayAuditMenuTests.testAQuarantinedServerOffersAReview and testAQuarantinedServerThatAlsoNeedsLoginOffersBothSignInAndReview only select the first matching item, so a duplicate would still pass.
Follow-up
Verified during final ZCode review of PR #1381 (low severity); current implementation is correct.
Summary
The tray menu currently avoids showing two “Review” rows when quarantine review is already the primary action. Keep that guarantee pinned in the native test suite.
Reproduction
The new primary-item logic can return
.open(.review)for a quarantined server. The tray builder then also appends its independent quarantine Review row unlessprimaryOpensReviewis set and checked.TrayAuditMenuTests.testAQuarantinedServerOffersAReviewandtestAQuarantinedServerThatAlsoNeedsLoginOffersBothSignInAndReviewonly select the first matching item, so a duplicate would still pass.Follow-up
Reviewitem when review is the primary action.Reviewitem for quarantined + OAuth sign-in (Sign inprimary plus one Review path).Verified during final ZCode review of PR #1381 (low severity); current implementation is correct.