Repository navigation
docs(discord-rich-presence): key the reload trap to the log, not a timeout - #159
Merged
Merged
Conversation
…meout Since Paseo 0.12.0, `paseo plugin reload` waits until the daemon reports the plugin running or failed, with no 60-second client deadline (getpaseo/paseo#6306). The trap now starts from the log staying on `Stopping plugin` instead of a timeout that no longer comes. The remedy stays: `stopPlugin`'s SIGTERM and SIGKILL escalation is unchanged since 0.11.0, the version the trap was written against. Refs #155 Co-Authored-By: Claude Opus 5.5 <[email protected]>
7 tasks done
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Part 1 of #155.
Since Paseo 0.12.0,
paseo plugin reloadwaits until the daemon reports the plugin running or failed, with no 60-second deadline (getpaseo/paseo#6306).The trap now starts from the log, not from a timeout that no longer comes.
The remedy stays.
stopPlugin's SIGTERM and SIGKILL escalation has not changed since v0.11.0, the version the trap was written against, so it can't be shown to end the process on its own now.Evidence
After:
git diff v0.11.0 v0.12.0 -- packages/server/src/server/plugins/runtime.tschanges nothing in the SIGTERM/SIGKILL escalation, so the kill remedy is still needed.Merge Danger
Door: two-way
Blast Radius: none
Agent docs only; the minimum Paseo version doesn't change.