SK-3004: add mock CVV value tokens, fix empty CVV mock and rename CollectElementInput.table to tableName - #189
Merged
Conversation
… mock, add CVV tests - Rename CollectElementInput.table parameter to tableName; update all usages across SDK (Element, CollectContainer, ComposableContainer, TextField), samples, tests, and README - Fix CVV mock: capture empty-value CVV elements so their tokens are replaced with "" instead of leaking the real vault token; add explicit isEmpty guard at replacement site to avoid calling generateMockCVV(0,"") - Add 14 unit tests for MockCVV covering empty-entered-value (flat and nested), generateMockCVV(0) backstop, and all prior nested-path cases Co-Authored-By: Claude Sonnet 4.6 <[email protected]>
saileshwar-skyflow
changed the title
Devesh-Skyflow
approved these changes
Jul 31, 2026
yaswanth-pula-skyflow
approved these changes
Jul 31, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
CollectElementInput.table→tableName: renamed the constructor parameter for consistency; updated all internal SDK usages (Element,CollectContainer,ComposableContainer,TextField), samples, tests, and READMECVVMap.capture(), causing the real vault token to be returned to the app. Empty-value CVV elements are now captured and their tokens replaced with"". An explicitisEmptyguard at the replacement site ensuresgenerateMockCVVis never called with length 0generateMockCVVbackstop: existingif (length <= 0) return ""guard confirmed and tested directlyAdditionalFieldsRecord.datavalues that areMap<*, *>are now serialized asJSONObjectviaanyToJsonValue()instead of.toString()replaceCVVTokensInRecordto use first-dot split + exactpathfield matching so nested columns (e.g.address.city.street) replace only the correct token entry