Skip to content

docs(sjskills): route in-repo skills to local [[direct]] sources - #31

Merged
sjunepark merged 1 commit into
mainfrom
claude/sjskills-skill-local-sources
Oct 6, 2026
Merged

sjunepark merged 1 commit into
mainfrom
claude/sjskills-skill-local-sources

Conversation

@sjunepark

Copy link
Copy Markdown
Owner

Follow-up to #29.

references/project-selection.md already documented local path sources. The main SKILL.md workflow, though, still described [[direct]] as only for external skills, and the reference's intro said "skills from other repositories". As a result, an agent asked to load a project's own skill could copy it into a managed root by hand, and strict sync would then quarantine it.

  • SKILL.md: a skill the project develops in its own tree is also a [[direct]] entry with a local path source; it must never be copied or symlinked by hand.
  • references/project-selection.md: the intro now includes skills developed in the project's own tree.
  • evals/evals.json: new case 22, for loading and syncing an in-repo skill.

Validation: scripts/validate-skills passes.

🤖 Generated with Claude Code

The project-selection reference documented local path sources, but the
skill's main workflow still described [[direct]] as only for external
skills, so an agent asked to load a project's own skill could hand-copy it
into a managed root, where strict sync quarantines it. Point that case at a
local-path [[direct]] entry and add an eval for it.

Co-Authored-By: Claude Opus 5.5 <[email protected]>
@sjunepark sjunepark added the coderabbit-review Request an initial CodeRabbit review label Oct 6, 2026
@chatgpt-codex-connector

chatgpt-codex-connector Bot commented Oct 6, 2026 •

Copy link
Copy Markdown

Codex Review Summary

This comment shows the latest Codex review activity on this pull request.

Review Status Commit Review trigger
📝 Code Review ✅ Completed 2026-10-06T02:19:25.144415Z 06003ad PR opened
ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review" or "@codex security review".

Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings.

@coderabbitai

coderabbitai Bot commented Oct 6, 2026

Copy link
Copy Markdown

Review in Change Stack →

No actionable comments were generated in the recent review. 🎉

ℹ️ Recent review info
⚙️ Run configuration
  • Configuration used: Repository: sjunepark/coderabbit/.coderabbit.yaml
  • Review profile: ASSERTIVE
  • Plan: Essentials
  • Run ID: a7ae382b-2b87-46a4-8a11-a71839d85067
📥 Commits

Reviewing files that changed from the base of the PR and between e89092d and 06003ad.

📒 Files selected for processing (3)
  • skills/sjskills/SKILL.md
  • skills/sjskills/evals/evals.json
  • skills/sjskills/references/project-selection.md

Included review availability: This review used your included allowance. 3 included reviews remain after this review. Your included PR review attempts over the past 7 days set your current allowance at 5 reviews per hour.


📝 Summary

Summary by CodeRabbit

  • Documentation
    • Clarified that skills developed within a project can be declared in its manifest using a direct entry with a local path.
    • Added guidance not to manually copy or symlink project-local skills into a managed root.
    • Retained the instruction to use the repository’s plugin workflow for Codex plugins.
    • Added an evaluation case covering project-local skill setup, installation planning, and applying later edits.

Walkthrough

The project skill workflow now covers declaring project-developed skills through [[direct]] entries with local path sources. Project-selection guidance and evaluation case 22 describe this approach.

Changes

Project-local skill guidance

Layer / File(s) Summary
Direct local-source guidance
skills/sjskills/SKILL.md, skills/sjskills/references/project-selection.md, skills/sjskills/evals/evals.json
The skill instructions and project-selection guidance specify [[direct]] entries with local path sources for project-developed skills. Evaluation case 22 specifies the expected output, including plan/apply and re-planning when installation is requested.

Priority: ⬇️ Low

Estimated code review effort: 2 (Simple) | ~8 minutes

Change: Other

Merge Risk: ⚪ Minimal · up to 06003

The documented project-local skill workflow matches the manifest and synchronization behavior. No actionable merge-blocking risk is evident.

🚥 Pre-merge checks | ✅ 5
✅ Passed checks (5 passed)
Check name Status Explanation
Title check ✅ Passed The title clearly summarizes the main change: routing in-repository skills through local [[direct]] sources.
Description check ✅ Passed The description explains the documentation updates, their purpose, the new evaluation case, and reported validation. It is related to the changeset.
Docstring Coverage ✅ Passed No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check. Docstring coverage is scoped to functions touched by this diff. Analyzed 0 functions across 0…
Linked Issues check ✅ Passed Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check ✅ Passed Check skipped because no linked issues were found for this pull request.
✨ Finishing Touches
🧪 Generate unit tests (beta)
  • Commit to this branch
  • Create a new PR
  • Autopilot · Keep fixing CodeRabbit findings and required CI, and resolving merge conflicts

Comment @coderabbitai help to get the list of available commands.

@sjunepark
sjunepark merged commit cf42509 into main Oct 6, 2026
8 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

coderabbit-review Request an initial CodeRabbit review

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant