Skip to content

Support authenticated GitHub skill profiles and preserve local authoring updates #23

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
sjunepark merged 7 commits into from
Sep 10, 2026
Merged

Support authenticated GitHub skill profiles and preserve local authoring updates #23

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
7 commits
Select commit Hold shift + click to select a range
f689e91
Refine skill authoring authority and evaluation records
sjunepark Sep 10, 2026
e1529ff
wip(registry): recover private KICPA additions onto current main
sjunepark Sep 10, 2026
c58fb15
Merge local work, origin main, and PR 22 into a draft integration branch
sjunepark Sep 10, 2026
6322c48
docs: record draft publication boundary for combined integration
sjunepark Sep 10, 2026
84ba2e7
feat(sjskills): reconcile explicit authenticated GitHub skill selections
sjunepark Sep 10, 2026
9e6dd98
docs: record verified private-source acceptance and delivery evidence
sjunepark Sep 10, 2026
cad1bf2
Fix authenticated source pins, URL validation, and skipped managers
sjunepark Sep 10, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
25 changes: 25 additions & 0 deletions PROGRESS.md
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,3 +1,28 @@
# Authenticated private-source delivery

PR #23 review follow-up: confirmed comments 3979633085 (commit pins), 3979633091 (unsupported GitHub page URLs), and 3979633101 (manual/workflow validation). Fixed with regression coverage; PR checks own follow-up native validation and the merge gate.

- PR #23 combines local skill-authoring work, origin main, and the PR #22
recovery history. Public `kicpa` membership is restored; recovered private
registrations now belong to `kicpa-private`.
- Access validation/resolution, controlled Git/gh staging, evidence separation,
and compatible public-plan loading are implemented. The
[private-source plan](plans/sjskills-private-github-sources.md) owns the design
and acceptance evidence. Original recovery stash remains
`038118178cce4759e3acebf854f19b36723488fc`.
- Full Go/race suites, vet, Node tests, release tests, and skill validation
passed on macOS. Bounded independent review found no implementation defect;
its requested native auth cancellation coverage and token-login acceptance
were added and passed. Operator documentation and the plugin bundle agree.
- Implementation `84ba2e7` passed source checks and hosted native acceptance on
macOS Intel/ARM and Windows in
[run 34482396368](https://github.com/sjunepark/agent-scripts/actions/runs/34482396368).
[PR #23](https://github.com/sjunepark/agent-scripts/pull/23) owns the final merge
status and final check results. CodeRabbit skipped its
requested review because automatic reviews are disabled.
- No new release, actual private-skill installation, or real-machine
reconciliation is included.

# sjskills maintenance plugin delivery

- User authorized automatic CLI updates and configured skill sync on every
Expand Down
9 changes: 8 additions & 1 deletion README.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -145,7 +145,14 @@ sjskills apply
```

`sjskills.toml` may combine named profiles with direct third-party
declarations. In a project that adopts this ownership model, ignore
declarations. `sjskills profiles` reports their access requirements. `kicpa`
stays public; add `kicpa-private` for the enrolled private catalog. A direct
entry can set `access = "github-authenticated"` to use an existing gh login
for a GitHub.com source. See the [access contract](docs/skill-registry.md#skill-and-source-records)
for dependencies, supported configuration, and failure handling. Use a build
that supports these fields; this source change does not publish a new release.

In a project that adopts this ownership model, ignore
`.sjskills/`, `.agents/skills/`, and `.claude/skills/`; do not add those
patterns until any preexisting committed content has been reviewed and
migrated. Review every plan before apply. Sync removes undeclared skills from
Expand Down
Loading