[Warlock] Implement Impetuous Wrath and 12.1.0 Affliction updates#11638
Merged
nyterage merged 1 commit intoJul 26, 2026
Merged
Conversation
millanzarreta
marked this pull request as ready for review
July 26, 2026 08:47
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR implements the latest Affliction Warlock changes made by Blizzard on the 12.1.0 PTR (as of 2026-07-26). The latest Demonology tuning changes consist only of spell data modifications and do not require any code changes.
Changes intended for 12.1.0 are guarded behind version checks. The existing behavior for versions
<12.1.0remains unchanged.Impetuous Wrath
The new Impetuous Wrath talent has been implemented for versions
>=12.1.0, replacing Nocturnal Yield.Impetuous Wrath increases Shadow Bolt, Drain Soul, Malefic Grasp, and Dark Harvest damage by 10%, or by 20% when the target is affected by Haunt.
Effects #1 and #2 apply to Shadow Bolt/Drain Soul/Malefic Grasp, while effects #3 and #4 apply to Dark Harvest. These are dummy effects (likely server-side scripted), so they need to be implemented manually.
The target's Haunt state is evaluated according to the behavior observed in-game:
Nocturnal Yield and its associated Seed of Corruption interactions are now restricted to versions
<12.1.0.The default Affliction APL has also been updated to avoid referencing
talent.nocturnal_yieldin versions>=12.1.0, since that talent no longer exists and would otherwise cause errors.Shard Instability
Shard Instability has been redesigned on the 12.1.0 PTR. Its buff can now make either Unstable Affliction or Seed of Corruption free and instant.
The chance to trigger Shard Instability is unchanged:
There is currently a bug on the PTR where Seed of Corruption benefits from Shard Instability but does not consume the buff. Without the Affliction 4pc tier bonus, this allows Seed of Corruption to be cast repeatedly for free and instantly while the buff remains active.
With the Affliction 4pc tier bonus, the additional Unstable Affliction applied by Seed of Corruption still consumes Shard Instability. This existing PTR bug remains unchanged.
As with Unstable Affliction, if Shard Instability is gained during the cast, that cast benefits from the Soul Shard cost reduction but does not consume the buff. This was already the behavior in previous versions and remains unchanged.
Nightfall and Malefic Grasp
The interaction between Nightfall and Malefic Grasp has changed on the 12.1.0 PTR.
On live 12.0.7, Malefic Grasp does not benefit from the Nightfall damage increase under any circumstances. On the 12.1.0 PTR, it now benefits from the damage increase, but only when using the Necrolyte Teachings Soul Harvester hero talent (like Drain Soul does). This remains bugged (also like Drain Soul is), since Malefic Grasp should presumably benefit from Nightfall regardless of the selected hero talents.
Additional automatically parsed changes
The latest spell data also includes several changes that do not require new manual implementations:
The patch notes describe Flames of Xoroth as being reduced from
4%to3%. However, spell data applies a-1%percent modifier to the existing4%effects, resulting in an actual value of3.96%. This3.96%value has been confirmed in-game and matches the spell data. This appears to be a clear bug and will likely be fixed in the future.