Repository navigation
install: check archive paths with is_relative_to, not a string prefix - #57
Draft
ShahriarAhnaf wants to merge 1 commit into
Draft
ShahriarAhnaf wants to merge 1 commit into
ShahriarAhnaf wants to merge 1 commit into
Conversation
Co-Authored-By: Claude Opus 5.5 <[email protected]>
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
_unpack_zipcompared resolved paths as strings, so an entry resolving into a sibling directory that shares the prefix (.engine.incoming-evil) passed the check.zipfile.extractallalready normalises.., and payloads are sha256-pinned by the signed manifest, so this tightens the guard rather than closing a reachable hole.Tested: new
test_unpack_zip_refuses_a_sibling_sharing_the_prefixfails on the old check and passes on the new one.tests/test_install.py: 64 passed.🤖 Generated with Claude Code