Skip to content

SF-3747 Allow showing drafted chapters not present in standard translations - #4063

Draft
RaymondLuong3 wants to merge 3 commits into
masterfrom
feature/sf-3747-draft-chapters
Draft

SF-3747 Allow showing drafted chapters not present in standard translations#4063
RaymondLuong3 wants to merge 3 commits into
masterfrom
feature/sf-3747-draft-chapters

Conversation

@RaymondLuong3

@RaymondLuong3 RaymondLuong3 commented Aug 20, 2026

Copy link
Copy Markdown
Collaborator

This PR will allow projects to show the extra chapters that may be present in a draft that are non-standard. It calculates the draft chapters that are present based on the versification and from what is stored in MongoDB. The editor component listens to the number of chapters returned when the generated draft tab is opened and updates its list of chapters accordingly.


This change is Reviewable

@codecov

codecov Bot commented Aug 20, 2026

Copy link
Copy Markdown

Codecov Report

❌ Patch coverage is 67.85714% with 9 lines in your changes missing coverage. Please review.
✅ Project coverage is 81.02%. Comparing base (c319a60) to head (570facb).
✅ All tests successful. No failed tests found.

Files with missing lines Patch % Lines
...SIL.XForge.Scripture/Services/MachineApiService.cs 66.66% 0 Missing and 5 partials ⚠️
...anslate/draft-generation/draft-handling.service.ts 0.00% 2 Missing ⚠️
...ntApp/src/app/translate/editor/editor.component.ts 75.00% 2 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##           master    #4063      +/-   ##
==========================================
- Coverage   81.03%   81.02%   -0.01%     
==========================================
  Files         661      661              
  Lines       43105    43118      +13     
  Branches     7056     7038      -18     
==========================================
+ Hits        34929    34938       +9     
- Misses       7002     7017      +15     
+ Partials     1174     1163      -11     

☔ View full report in Codecov by Harness.
📢 Have feedback on the report? Share it here.

@RaymondLuong3
RaymondLuong3 deployed to screenshot_diff August 20, 2026 15:12 — with GitHub Actions Active
@github-actions

github-actions Bot commented Aug 20, 2026

Copy link
Copy Markdown
Contributor

No screenshot differences — all stories are identical.

View the diff page at: https://pr-4063--sf-screenshot-diffs.netlify.app

@RaymondLuong3 RaymondLuong3 added the will require testing PR should not be merged until testers confirm testing is complete label Aug 20, 2026
@RaymondLuong3
RaymondLuong3 force-pushed the feature/sf-3747-draft-chapters branch from 833f8ec to 570facb Compare August 20, 2026 15:27
@RaymondLuong3
RaymondLuong3 deployed to screenshot_diff August 20, 2026 15:34 — with GitHub Actions Active
@RaymondLuong3
RaymondLuong3 marked this pull request as draft August 20, 2026 15:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

will require testing PR should not be merged until testers confirm testing is complete

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant