rts: add activity logging to give context for resource usage reports - #4061
rts: add activity logging to give context for resource usage reports#4061marksvc wants to merge 2 commits into
Conversation
|
This branch has |
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## task/rts-connect #4061 +/- ##
====================================================
+ Coverage 81.10% 81.11% +0.01%
====================================================
Files 661 664 +3
Lines 43061 43192 +131
Branches 7054 7094 +40
====================================================
+ Hits 34925 35036 +111
- Misses 6963 6984 +21
+ Partials 1173 1172 -1 ☔ View full report in Codecov by Harness. |
|
✅ No screenshot differences — all stories are identical. View the diff page at: https://pr-4061--sf-screenshot-diffs.netlify.app |
|
Devin posted a concern about this. The main problem is pre-existing, and I am drafting a fix for it to go into a separate PR. (null |
|
Devin has expressed some concern about incompleteness of the logging, such as if an op submission is later rejected for permission reasons. In practice, the activity logger needs to show where the heavy or frequent activity is happening, rather than infrequent or special situations. There may be some logging that is missing that would be relevant for identifying heavy activity. So that's something to keep an eye out for. |
|
Devin mentions that there is no log bound or rotation. I had a look at this and it looks like it shouldn't be too challenging to set up if we need it. We can do it at the system level; it looks like the application doesn't need additional changes to make that possible. |
|
Devin is concerned about multiple processes writing to the log at the same time. We only run one RealtimeServer at a time. |
Open in Devin Review
This change is