Skip to content

Move optional dependencies out of "dependencies" - #357

Open
Enkidu93 wants to merge 2 commits into
mainfrom
fix-optional-dependencies
Open

Move optional dependencies out of "dependencies"#357
Enkidu93 wants to merge 2 commits into
mainfrom
fix-optional-dependencies

Conversation

@Enkidu93

@Enkidu93 Enkidu93 commented Aug 20, 2026

Copy link
Copy Markdown
Collaborator

Fixes #356. I've confirmed that this is now compatible with silnlp.


This change is Reviewable

@Enkidu93
Enkidu93 requested review from ddaspit and pmachapman August 20, 2026 21:10
@codecov-commenter

codecov-commenter commented Aug 20, 2026

Copy link
Copy Markdown

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 92.02%. Comparing base (d496ff6) to head (4c869fe).

Additional details and impacted files
@@           Coverage Diff           @@
##             main     #357   +/-   ##
=======================================
  Coverage   92.02%   92.02%           
=======================================
  Files         389      389           
  Lines       24485    24485           
=======================================
  Hits        22532    22532           
  Misses       1953     1953           

☔ View full report in Codecov by Harness.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@ddaspit ddaspit left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

:lgtm:

@ddaspit reviewed 3 files and all commit messages, and made 1 comment.
Reviewable status: :shipit: complete! all files reviewed, all discussions resolved (waiting on pmachapman).

@pmachapman pmachapman left a comment

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

:lgtm:

@pmachapman reviewed 3 files and all commit messages, and made 1 comment.
Reviewable status: :shipit: complete! all files reviewed, all discussions resolved (waiting on Enkidu93).

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Fix optional dependency specification

4 participants