Remove PHP Source update readme - #23
Open
hahn-kev wants to merge 2 commits into
Open
Conversation
Replace the PHP install README and remove the PHP API, Apache image, and Eclipse project files so the repo matches the C# container as the supported server. Co-authored-by: Cursor <[email protected]>
Co-authored-by: Cursor <[email protected]>
rmunn
approved these changes
Aug 20, 2026
rmunn
left a comment
rmunn
left a comment
Collaborator
There was a problem hiding this comment.
One deleted file that maybe should be copied over to the C# side first before being deleted (if it's actually used in tests), then this LGTM.
Comment on lines
-1
to
-5
| e0d330954fcc: | ||
| a42fd4ccc794: | ||
| 3c6430f2d5dd: | ||
| 6cd9bca9ffe5: | ||
| da48e222f3a8: |
Collaborator
There was a problem hiding this comment.
This file (and only this file) is missing from https://github.com/sillsdev/hgresume/tree/master/csharp/test/HgResume.HttpTests/data — was it deliberately omitted because the C# version of the tests don't use it? Or is this list of five revisions used in some test or other, and should be copied into the C# tree before being deleted?
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Removed all the PHP source, updated the readme, with a link to the old source.
This change is