Skip to content

TT-7626 ignore orgs without attributes - #520

Merged
gtryus merged 1 commit into
developfrom
TT-7626
Aug 21, 2026
Merged

TT-7626 ignore orgs without attributes#520
gtryus merged 1 commit into
developfrom
TT-7626

Conversation

@sarahentzel

Copy link
Copy Markdown
Collaborator

let indexeddb finish before shutting it down to add/remove remote

let indexeddb finish before shutting it down to add/remove remote
@gtryus
gtryus force-pushed the develop branch 2 times, most recently from 88b8855 to c2ddd39 Compare August 21, 2026 03:26
@sarahentzel
sarahentzel marked this pull request as ready for review August 21, 2026 13:39
@sarahentzel
sarahentzel requested a lite review from Copilot August 21, 2026 13:39

Copilot AI left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

This PR improves renderer robustness in two areas: (1) preventing IndexedDB backup-restore races during Electron source (re)configuration, and (2) avoiding crashes when organization records are missing attributes in the admin teams list.

Changes:

  • In Electron, explicitly await restoreBackup before coordinator/source teardown so IndexedDB restore finishes before deactivate() can close the DB.
  • Ensure the backup source’s IndexedDB is opened after coordinator activation where applicable.
  • Filter out organizations without attributes in useAdminTeams to avoid downstream access/sort errors.

Reviewed changes

Copilot reviewed 3 out of 3 changed files in this pull request and generated no comments.

File Description
src/renderer/src/Sources.tsx Awaits backup restore in Electron before remote reconfiguration/deactivation; ensures backup DB is opened after activation.
src/renderer/src/crud/restoreBackup.ts Opens IndexedDB cache if needed before waiting on migration; resets the shared restore promise on error to allow retries.
src/renderer/src/components/useAdminTeams.ts Skips org records missing attributes to prevent invalid access during filtering/sorting.

💡 Add a code-review agent skill or configure MCP servers for context-aware, tailored reviews. Learn more in the docs.

@gtryus
gtryus merged commit 2271a97 into develop Aug 21, 2026
3 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants