Conversation
let indexeddb finish before shutting it down to add/remove remote
gtryus
force-pushed
the
develop
branch
2 times, most recently
from
August 21, 2026 03:26
88b8855 to
c2ddd39
Compare
sarahentzel
marked this pull request as ready for review
August 21, 2026 13:39
Contributor
There was a problem hiding this comment.
Pull request overview
This PR improves renderer robustness in two areas: (1) preventing IndexedDB backup-restore races during Electron source (re)configuration, and (2) avoiding crashes when organization records are missing attributes in the admin teams list.
Changes:
- In Electron, explicitly await
restoreBackupbefore coordinator/source teardown so IndexedDB restore finishes beforedeactivate()can close the DB. - Ensure the backup source’s IndexedDB is opened after coordinator activation where applicable.
- Filter out organizations without
attributesinuseAdminTeamsto avoid downstream access/sort errors.
Reviewed changes
Copilot reviewed 3 out of 3 changed files in this pull request and generated no comments.
| File | Description |
|---|---|
src/renderer/src/Sources.tsx |
Awaits backup restore in Electron before remote reconfiguration/deactivation; ensures backup DB is opened after activation. |
src/renderer/src/crud/restoreBackup.ts |
Opens IndexedDB cache if needed before waiting on migration; resets the shared restore promise on error to allow retries. |
src/renderer/src/components/useAdminTeams.ts |
Skips org records missing attributes to prevent invalid access during filtering/sorting. |
💡 Add a code-review agent skill or configure MCP servers for context-aware, tailored reviews. Learn more in the docs.
gtryus
approved these changes
Aug 21, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
let indexeddb finish before shutting it down to add/remove remote