LT-22728: Scope local libraries to one build - #1105
Open
johnml1135 wants to merge 4 commits into
Open
Conversation
Capture the one-invocation selection contract and test-first plan. Refs LT-22728
Pack explicitly selected SIL dependencies before restore and pass their versions as global properties instead of editing SilVersions.props. Remove filesystem-sourced NuGet cache entries and managed local feed packages before each build while retaining published package caches. Refs LT-22728
Keep the durable workflow in the architecture guide and carry review decisions and verification evidence in the pull request. Refs LT-22728
Add the local feed through RestoreAdditionalProjectSources so the repository's configured nuget.org source remains valid during solution restore. Cover selected-family eviction of same-version published cache entries.
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #1105 +/- ##
==========================================
- Coverage 38.34% 38.34% -0.01%
==========================================
Files 1507 1507
Lines 350586 350586
Branches 40294 40294
==========================================
- Hits 134448 134445 -3
- Misses 186911 186915 +4
+ Partials 29227 29226 -1 🚀 New features to boost your workflow:
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Local SIL libraries now last for one FieldWorks build only.
\.\build.ps1 -LocalLibraries machinerebuilds and uses Machine. The nextbuild without that option automatically removes local Machine packages and uses
the published package. Published HTTP packages stay cached, so ordinary builds
do not redownload them every time.
Review these:
build.ps1: the named libraries are the complete local set for this build.Build/LocalLibraries.psm1: ordinary cleanup removes only filesystem-sourcedpackages; selected libraries also evict same-version published cache entries.
Build/LocalLibraries.Tests.ps1: covers all five supported library familiesand the cleanup boundaries.
No user-level NuGet source or local version is persisted. The intentional
Manage-LocalLibraries.ps1 -Library/-Versionworkflow still works.Proof: local Machine 3.9.2 build passed, then an ordinary build removed 2
cache entries and 4 feed packages, restored the different nuget.org package,
and passed. Luna review: GO. Final CI: 5,775 passed, 0 failed; all checks
green.
Next: verify the cleanup boundary, then approve.
LT-22728
This change is