Skip to content

LT-22641: Fix crash restoring a project from another computer - #1103

Open
papeh wants to merge 2 commits into
mainfrom
bugfix/LT-22641-user-settings-crash
Open

LT-22641: Fix crash restoring a project from another computer#1103
papeh wants to merge 2 commits into
mainfrom
bugfix/LT-22641-user-settings-crash

Conversation

@papeh

@papeh papeh commented Aug 21, 2026

Copy link
Copy Markdown
Contributor

When getting the current dictionary configuration from the property table, ensure that the file exists. If the settings were restored from another computer, paths might not match, leading to a crash.

CI-ready checklist

  • Commit messages follow .github/commit-guidelines.md.
  • As much as possible, the change is unit tested.
  • Builds & tests pass locally (or I've run the CI-style build via build.ps1, test.ps1, or MSBuild).
  • If this is core-developer AI-assisted work, I followed Docs/workflows/ai-pr-workflow.md and ran pr-preflight or the equivalent branch-readiness review before requesting review.
  • For any Src/** folders touched, corresponding AGENTS.md files are updated or explicitly confirmed still accurate.
  • I have considered all comments from an AI code reviewer (such as Devin)

This change is Reviewable

@github-actions

github-actions Bot commented Aug 21, 2026

Copy link
Copy Markdown

Comment hygiene (advisory)

1 comment-style violation(s) in the lines this branch adds since origin/main.
Advisory only -- no check fails on these, and the same violations appear as inline warnings on the Files changed tab.

File Category Comment
Src/xWorks/DictionaryExportService.cs:136 comment-too-long 254 chars (budget 200): ReSharper disable once ObjectCreationAsStatement - The Reversal Co...

Fix them per .claude/skills/fieldworks-code-commenting/SKILL.md.
Running .\build.ps1 -CommentHygiene (or .\test.ps1 -CommentHygiene) enforces them locally, and
re-wraps over-wide lines and repairs non-ASCII punctuation as it goes.

@papeh
papeh force-pushed the bugfix/LT-22641-user-settings-crash branch from d72540d to cc63a40 Compare August 21, 2026 16:59
@github-actions

github-actions Bot commented Aug 21, 2026

Copy link
Copy Markdown

NUnit Tests

    1 files  ±0      1 suites  ±0   11m 11s ⏱️ +25s
5 857 tests +1  5 776 ✅ +1  81 💤 ±0  0 ❌ ±0 
5 866 runs  +1  5 785 ✅ +1  81 💤 ±0  0 ❌ ±0 

Results for commit 3d53e58. ± Comparison against base commit 064f6a2.

♻️ This comment has been updated with latest results.

@codecov-commenter

codecov-commenter commented Aug 21, 2026

Copy link
Copy Markdown

Codecov Report

❌ Patch coverage is 71.42857% with 6 lines in your changes missing coverage. Please review.
✅ Project coverage is 38.34%. Comparing base (064f6a2) to head (3d53e58).

Files with missing lines Patch % Lines
Src/xWorks/DictionaryConfigurationListener.cs 62.50% 2 Missing and 1 partial ⚠️
Src/xWorks/DictionaryExportService.cs 0.00% 3 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main    #1103      +/-   ##
==========================================
- Coverage   38.34%   38.34%   -0.01%     
==========================================
  Files        1507     1507              
  Lines      350586   350582       -4     
  Branches    40294    40294              
==========================================
- Hits       134448   134434      -14     
- Misses     186911   186921      +10     
  Partials    29227    29227              
Files with missing lines Coverage Δ
Src/xWorks/DictionaryConfigurationController.cs 84.49% <100.00%> (ø)
Src/xWorks/DictionaryConfigurationListener.cs 38.23% <62.50%> (-1.48%) ⬇️
Src/xWorks/DictionaryExportService.cs 49.50% <0.00%> (-0.25%) ⬇️

... and 1 file with indirect coverage changes

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

* When getting the current dictionary configuration from the property table,
ensure that the file exists. If the settings were restored from another
computer, paths might not match, leading to a crash.
* Default to dictionary configuration to prevent loading others unnecessarily.
@papeh
papeh force-pushed the bugfix/LT-22641-user-settings-crash branch 2 times, most recently from 8997eb2 to 9b09c10 Compare August 21, 2026 19:26
Co-authored-by: Copilot <[email protected]>
@papeh
papeh force-pushed the bugfix/LT-22641-user-settings-crash branch from 9b09c10 to 3d53e58 Compare August 21, 2026 19:29
@papeh
papeh marked this pull request as ready for review August 21, 2026 19:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants