Repoint nine skill references that resolved from nowhere - #1102
Closed
johnml1135 wants to merge 1 commit into
Closed
Repoint nine skill references that resolved from nowhere#1102johnml1135 wants to merge 1 commit into
johnml1135 wants to merge 1 commit into
Conversation
Nine cross-references in the Avalonia migration and WinApp skills were written relative to the skill root while the citing file lives inside references/, so they resolved to references/references/<name>.md and pointed at nothing. Every target exists; only the paths were wrong. Seven become plain sibling names, which is what a file inside references/ needs to reach the file next to it. Two genuinely cross skill boundaries and become repo-root paths: winforms-avalonia-parity cites parity-evidence in the migration skill, and architecture-patterns cites style-system in the Avalonia UI skill. Nothing else changed. No prose, no guidance, no file moved or renamed. Verified by resolving every reference in every .claude markdown file from the directory it is written in: nine dangling before, none after. Co-Authored-By: Claude Opus 5 <[email protected]>
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #1102 +/- ##
=======================================
Coverage 38.33% 38.34%
=======================================
Files 1507 1507
Lines 350580 350580
Branches 40293 40293
=======================================
+ Hits 134410 134415 +5
+ Misses 186941 186937 -4
+ Partials 29229 29228 -1 🚀 New features to boost your workflow:
|
This was referenced Aug 21, 2026
Contributor
Author
|
Consolidated into #1100 by cherry-pick; the commit is preserved verbatim there. Closing. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Nine cross-references in the Avalonia migration and WinApp skills pointed at nothing. An agent following one —
lessons-learned.mdsending you toreferences/architecture-patterns.md, say — got a miss and carried on without the guidance it was told to read.Start here:
.claude/skills/fieldworks-winforms-to-avalonia-migration/references/lessons-learned.md— three of the nine are in that one file, and the shape is identical in all nine.Where to look:
references/, soreferences/architecture-patterns.mdresolved toreferences/references/architecture-patterns.md.references/needs to reach the file next to it.winforms-avalonia-parity.mdcitesparity-evidence.mdin the migration skill, andarchitecture-patterns.mdcitesstyle-system.mdin the Avalonia UI skill. Those two were never fixable as siblings.Deliberately not here: no checker is added to stop this recurring. Worth doing, but it belongs with whoever owns skill tooling rather than bolted onto a path fix.
Verification: every reference in every
.claudemarkdown file was resolved from the directory it is written in — nine dangling before, zero after.gitlintclean. Nobuild.ps1ortest.ps1: markdown only, no compiled code.Next: review and merge — independent of #1098/#1099/#1100/#1101 and touches none of their files.
The nine, and where each now points
fieldworks-winapp/navigation/winforms-avalonia-parity.mdreferences/parity-evidence.md.claude/skills/fieldworks-winforms-to-avalonia-migration/references/parity-evidence.mdfieldworks-winapp/references/research.mdreferences/how-to-update.mdhow-to-update.md…migration/references/architecture-patterns.mdfieldworks-avalonia-ui/references/style-system.md.claude/skills/fieldworks-avalonia-ui/references/style-system.md…migration/references/control-exemplar-map.mdreferences/lessons-learned.mdlessons-learned.md…migration/references/lessons-learned.mdreferences/architecture-patterns.mdarchitecture-patterns.md…migration/references/lessons-learned.mdreferences/migration-checklist.mdmigration-checklist.md…migration/references/lessons-learned.mdreferences/parity-evidence.mdparity-evidence.md…migration/references/migration-checklist.mdreferences/lessons-learned.mdlessons-learned.md…migration/references/migration-checklist.mdreferences/seam-catalog.mdseam-catalog.mdHow these were found
Not by reading. They surfaced while verifying that a different change — the skill compression in #1100 — had not broken any pointers. The check resolves every path-like
.mdreference inside.claudefrom the directory of the file that writes it, and reports the misses.That check found one genuine regression introduced by #1099 (fixed there) and these nine, which predate all of this work. They are split into this PR precisely because they are unrelated to it: an unrelated fix riding along in a compression PR is how a reviewer loses track of what they approved.
The same check is what verifies this PR. It is currently a throwaway script rather than something in CI — see "deliberately not here" above.
This change is