Repository navigation
Test and document Default for Rust records with zero-argument constructors - #10
Merged
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Add compiled regression tests and documentation for the Rust builder plugin's existing
Defaultimplementation. The tests cover empty records, fields marked#[default], and optional generic fields whose type argument does not implementDefault.Rationale
Records with a zero-argument
new()already implementDefaultby callingSelf::new(), but this behavior was undocumented and had no dedicated regression coverage. The tests verify the generated code compiles and thatdefault()andnew()produce the same values and JSON representation.Validation
cargo test -p sidex-serde-tests -p sidex-gen-rs --locked: 15 tests passed.cargo clippy -p sidex-serde-tests -p sidex-gen-rs --all-targets --all-features --locked -- -D warnings: passed.cargo +nightly-2026-07-14 fmt --all -- --check: passed.uv run --project tests/py --locked pytest -q tests/py/test_json_serde.py tests/py/test_mypy.py: 59 tests passed.Created on behalf of @koehlma by Codex / GPT-6-astra (high) · Task