Repository navigation
Conversation
Collaborator
|
Thanks @ac1982 for your PR! I normally check PRs on weekends. However, I have to go out of town this weekend, so I might reply a bit later than usual. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Repeatedly serializing the same
GoPdfappends page and content references again, so a one-page document becomes a two-page PDF on its second export. Protected documents also gain a new encryption object each time.Rebuild the derived page references during
prepareand reuse the existing encryption object. This keeps repeated exports stable while still including pages added after an earlier export.Fixes #327.
Validation:
GetBytesPdfReturnErr,WriteTo,WritePdf, retry after a failed destination write, and adding a page between exports. It fails on the original implementation.mkdir -p test/out && go test -race -count=1 ./...andgo vet ./...pass on Go 1.27.1/Linux arm64.pdfinfocheck: export, repeat export, then add a page produces page counts 1/1/2, versus 1/2/4 and syntax errors before the fix.The existing behavior where
WriteTodiscards writer errors is unchanged; the retry test checks document stability, not error propagation.