Repository navigation
fix(tuios): prefix x / Xの確認を1キーで答えられるようにする - #449
Merged
Merged
Conversation
tmux の confirm-before と同じく y / n を押した時点で確定する。 remote session では popup がホスト側の dotfiles で動く点も文書化する。
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
prefix x/prefix Xの確認を、tmux のconfirm-beforeと同じく Enter なしの1キー(y/n)で答えられるようにする。Changes
tui confirmの入力をread_keyに変更。端末では raw mode で1文字読み、端末でない場合(パイプ)は1行読む。docs/tools/tuios.mdに、remote session では popup がそのホストの~/dotfilesで動くので、ホスト側もgit pull(dotsync)で揃える必要があることを追記。背景
remote session で
prefix xが効かなかった。原因は、ailab の dotfiles が #446 より前のままで、tui confirmがなかったこと。ailab はgit pull --ff-onlyで #448 まで更新済み。この PR をマージした後も、ailab で同じく pull が必要。Test plan
python3 scripts/test-tui.pyprefix xの後にnだけを押すと閉じず、yだけを押すと閉じることを確認(どちらも Enter なし)tui confirm paneにnを渡し、プロンプトが表示され、pane が閉じないことを確認🤖 Generated with Claude Code