Repository navigation
fix(tuios): prefix mをtmux-swap-pickerと同じ2段階選択にする - #443
Merged
Merged
Conversation
focus中paneを固定のsrcにして候補から外していたため、focus中paneを選べなかった。 tmux版と同じくfocus中paneを含むworkspace内のpaneからsrcとdstを順に選び、 入れ替え後はherdrが移したfocusを元のpaneへ戻す。
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
prefix mで focus 中の pane を選べなかった問題を直す。tmux のtmux-swap-pickerと同じく、入れ替える2つの pane を src → dst の順に選ぶ形にする。Changes
(focus)印付き）。これまでは focus 中の pane を固定の src にして候補から外していたため、選ぶことができなかった。pane swapは src に focus を移すので、入れ替え後に元々 focus していた pane へ戻す（tmux と同じ挙動）。docs/tools/tuios.mdのキー表を更新。Test plan
python3 scripts/test-tui.py（src 候補に focus 中の pane を含むこと、dst から src を除くこと、入れ替え後の focus 復元、src の取り消し）scripts/check-markdown-links.py/scripts/check-package-duplication.sh