Repository navigation
fix(tuios): prefix mの候補番号をpaneタイトルのworkspace内位置に揃える - #442
Merged
Merged
Conversation
pane タイトルの {index} は workspace 内で最小化されていない window の位置。
session 全体の index を使っていたため、scratch や他 workspace の pane の分だけ番号がずれていた。
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
prefix mの候補番号が、画面の pane タイトルの番号と一致していなかった問題を直す。Changes
{index}は、TUIOS のworkspacePositionと同じく「同じ workspace で最小化されていない window の 1 始まりの位置」。これまではlist-windowsの session 全体のindexを使っていたため、scratch や他の workspace の pane の分だけ番号がずれていた。Test plan
python3 scripts/test-tui.py（scratch・他 workspace・最小化・popup が混ざる配置で、候補が1: editor/3: logsになることを確認）1: live-pr/3: ~/dotfiles/4: ~/dotfilesとなり、画面のタイトル番号と一致した（修正前は4/5にずれていた）